Skip to content

Commit

Permalink
Merge pull request #65 from donpenney/fix-job-handling
Browse files Browse the repository at this point in the history
Fix hwmgr job handling
  • Loading branch information
openshift-merge-bot[bot] authored Dec 23, 2024
2 parents 14e9a79 + d1ff852 commit 7865e5a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions adaptors/dell-hwmgr/hwmgrclient/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -321,15 +321,15 @@ func (c *HardwareManagerClient) CheckJobStatus(ctx context.Context, jobId string
failReason = "unknown"
}
c.Logger.InfoContext(ctx, "Job has failed", slog.Any("status", status), slog.String("failReason", failReason))
return JobStatusFailed, failReason, fmt.Errorf("job has failed: %s", failReason)
return JobStatusFailed, failReason, nil
default:
if status.Brief.FailReason != nil {
failReason = *status.Brief.FailReason
} else {
failReason = "unknown"
}
c.Logger.InfoContext(ctx, "Job status is unknown", slog.Any("status", status), slog.String("failReason", failReason))
return JobStatusUnknown, failReason, fmt.Errorf("job status is unknown: %s", failReason)
return JobStatusUnknown, failReason, nil
}

return JobStatusCompleted, failReason, nil
Expand Down

0 comments on commit 7865e5a

Please sign in to comment.