Update dell-hwmgr adaptor to align with NodePool CRD changes #28
Conversation
Signed-off-by: Don Penney <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@donpenney: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| return fmt.Errorf("nodepool %s invalid: Expected 2 entries in .spec.nodeGroup, got %d", nodepool.Name, len(nodepool.Spec.NodeGroup)) | ||
| resourceTypeId := utils.GetResourceTypeId(nodepool) | ||
| if resourceTypeId == "" { | ||
| return fmt.Errorf("nodepool %s is missing resourceTypeId in spec", nodepool.Name) |
There was a problem hiding this comment.
nit: we could use the const utils.ResourceTypeIdKey in error print in case key name changes in the future.
|
/lgtm |
No description provided.