Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback NodePool Status Update Retry Mechanism #31

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

tliu2021
Copy link
Contributor

This update rolls back the previously implemented retry mechanism for updating the NodePool status. Since the IMS updates the NodePool's spec and metadata fields, conflicts can still occur if the NodePool status update is attempted on an outdated version of the resource.

@openshift-ci openshift-ci bot requested a review from browsell November 20, 2024 22:12
Copy link

openshift-ci bot commented Nov 20, 2024

@tliu2021: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-job cce240d link true /test ci-job
ci/prow/ci-bundle-operator-bundle cce240d link true /test ci-bundle-operator-bundle
ci/prow/images cce240d link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@donpenney
Copy link
Collaborator

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@donpenney donpenney merged commit 5b29f56 into openshift-kni:main Nov 27, 2024
4 of 8 checks passed
@tliu2021 tliu2021 deleted the rollback_retries branch December 4, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants