Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify deployment manager field mapping #30

Conversation

jhernand
Copy link
Collaborator

This patch changes the code that translates managed clusters into deployment managers. To do so it uses a set of jq queries that are compiled only once and executed in an almost declarative way.

Copy link

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jhernand. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This patch changes the code that translates managed clusters into
deployment managers. To do so it uses a set of jq queries that are
compiled only once and executed in an almost declarative way.

Signed-off-by: Juan Hernandez <[email protected]>
@jhernand jhernand force-pushed the simplify_deployment_manager_field_mapping branch from c8c5230 to 97c6a48 Compare November 22, 2023 15:49
@jhernand jhernand merged commit 45562d9 into openshift-kni:main Nov 22, 2023
6 of 7 checks passed
@jhernand jhernand deleted the simplify_deployment_manager_field_mapping branch November 22, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant