Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-16212: Implement sync mechanism for alarms collection #427

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

mlguerrero12
Copy link
Contributor

This implements a polling mechanism to sync the alarm dictionaries and definitions periodically.
It also handles the infrastructure server at a more generic level

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 24, 2024

@mlguerrero12: This pull request references CNF-16212 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This implements a polling mechanism to sync the alarm dictionaries and definitions periodically.
It also handles the infrastructure server at a more generic level

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mlguerrero12 mlguerrero12 force-pushed the syncsupport branch 2 times, most recently from 3a023e0 to 4d75cd7 Compare December 24, 2024 15:15
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 29, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2025
@mlguerrero12
Copy link
Contributor Author

@alegacy, @pixelsoccupied, PTAL

@alegacy
Copy link
Collaborator

alegacy commented Jan 10, 2025

/lgtm
/assign @pixelsoccupied

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@pixelsoccupied
Copy link
Collaborator

lgtm! Looks like some linter issue. Let's get it merged after the ci is happy.

This implements a polling mechanism to sync the
alarm dictionaries and definitions periodically.
It also handles the infrastructure server at a
more generic level

Signed-off-by: Marcelo Guerrero <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@mlguerrero12
Copy link
Contributor Author

@alegacy, @pixelsoccupied, fixed linter issue

@alegacy
Copy link
Collaborator

alegacy commented Jan 13, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
Copy link

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alegacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 869d574 into openshift-kni:main Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants