Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-16211: Add validating webhook for ProvisioningRequest #433

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Missxiaoguo
Copy link
Collaborator

@Missxiaoguo Missxiaoguo commented Jan 3, 2025

This is the initial commit to add a validation webhook for ProvisioningRequest. The webhook server is registered and starts when controller-runtime manager starts (default port: 9443). A follow-up commit will implement the logic for ValidateCreate() and ValidateUpdate() to handle validation during PR creation and updates.

Tested:
make run (webhook is disabled for local run)
make deploy
make bundle-build catalog-build bundle-run

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 3, 2025

@Missxiaoguo: This pull request references CNF-16211 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This is the initial commit to add a validation webhook for ProvisioningRequest. A follow-up commit will implement the logic for ValidateCreate() and ValidateUpdate() to handle validation during PR creation and updates.

Tested:
make run (webhook is disabled for local run)
make deploy
make bundle-build catalog-build bundle-run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 3, 2025

@Missxiaoguo: This pull request references CNF-16211 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This is the initial commit to add a validation webhook for ProvisioningRequest. The webhook server is registered and starts when controller-runtime manager starts (default port: 9443). A follow-up commit will implement the logic for ValidateCreate() and ValidateUpdate() to handle validation during PR creation and updates.

Tested:
make run (webhook is disabled for local run)
make deploy
make bundle-build catalog-build bundle-run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@irinamihai
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@Missxiaoguo
Copy link
Collaborator Author

Rebased to fix the conflict

@irinamihai
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@browsell
Copy link
Collaborator

browsell commented Jan 6, 2025

/approve

Copy link

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: browsell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 190b14c into openshift-kni:main Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants