-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantum on learn.openshift.com #882
Open
husky-parul
wants to merge
6
commits into
openshift-labs:master
Choose a base branch
from
husky-parul:katacoda
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@btannous Please review this. |
bttnns
suggested changes
Oct 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the scenario! I would like a few changes and/or comments before merging this in.
General Quantum Fixes
- Needs a description and intro description
- Since I talked to you openshift 4.5 is now released. If this should be able to run in OCP4.5 please update
index.json
to target this release. - I'd say this is
intermediate
level, quantum is complex but this is a getting started scenario - The ending step would be awesome to add links of where to get more information on OpenShift and Quantum here to direct students to additional information. Maybe include the link to the documentation that is currently in step 3 as well.
- Can we deploy this using the "Openshift Ibm Quantum Operator" or one of the other two (not sure why there are three) within the OpenShift OperatorHub instead of cloning a repo and pulling in the source?
- Maybe this would help with the "kernel error"?
The scenario does not work due to a jupyter kernel error
- Where is the image and source from where jupyter is running?
- Graham who used to work for red hat on our team put a bit of work into running jupyter on openshift, have you seen https://github.com/jupyter-on-openshift/jupyter-notebooks and are doing these things?
Step 1
- setting up IBMQ Account token, I highly suggest not using vi, I usually prefer vim personally but too many people get confused with the various modes and how to get into insert mode/save/and exit. There is a built in editor for katacoda that is in the browser, I'd prefer this if there are a good amount of editing. Can also use nano or sed or something else.
Step 2
- I'd tack this into the end of step 1. There is a template to use in markdown to automate the link instead of having to go through the openshift console.
Step 3
- We prefer not to link to other documentation. Can this or something similar be included into this markdown instead?
Step 4
- This looks like an awesome description! It should be put into the intro step!
Step 5
- Not sure what is different here from step 1. Is this different?
Step 6
- See notes of step 5.
- See notes of step 2 on the template link.
Let me know when this is ready for another look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenarios for using openshift-quantum-operators