rename manifest to payload in database #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
Signed-off-by: clyang82 <[email protected]>
qiujian16
approved these changes
Jun 12, 2024
machi1990
reviewed
Jun 14, 2024
| // Manifest holds the resource manifest in CloudEvent format (JSON representation). | ||
| Manifest datatypes.JSON `gorm:"type:json"` | ||
| // Payload is CloudEvent payload with CloudEvent format (JSON representation). | ||
| Payload datatypes.JSON `gorm:"type:json"` |
There was a problem hiding this comment.
FYI
I am seeing this
failed to create resource: maestro-9: Unable to create Resource: pq: column "payload" of relation "resources" does not exist
when I deploy the latest main against an existing deployment.
Ideally, this should've been a new migration file so that the column rename is applied. Renaming a column here, won't work for existing deployments as the migration id has already been applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.