enhance resource deletion flow. #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
force-pushed
the
br_enhance_resource_deletion
branch
from
8146a09 to
3d1be1e
Compare
morvencao
changed the title
|
/assign @qiujian16 @clyang82 @skeeey |
morvencao
force-pushed
the
br_enhance_resource_deletion
branch
from
3d1be1e to
6b844b6
Compare
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_enhance_resource_deletion
branch
from
6b844b6 to
6853f9d
Compare
clyang82
reviewed
Jun 7, 2024
|
|
||
| // set the deletedAt field if the resource has been marked as deleted | ||
| if !resource.DeletedAt.Time.IsZero() { | ||
| res.DeletedAt = openapi.PtrTime(resource.DeletedAt.Time) |
There was a problem hiding this comment.
why need this check? can we just use DeletedAt: = openapi.PtrTime(resource.DeletedAt)
There was a problem hiding this comment.
If we don't have this check, the deleted_at for HTTP response will be time zero value, instead of null.
|
ref: #101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhance the resource deletion flow by:
ManifestsDeletedconditionManifestsDeletedcondition in the status update and delete the resource record permanently.