Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking the version when update a resource with grpc #148

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

skeeey
Copy link
Contributor

@skeeey skeeey commented Jun 27, 2024

refer to #146

Copy link

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a small nitpick.
otherwise lgtm

The client can use the common.CloudEventsResourceVersionAnnotationKey annotation to make sure that the version is set. I'll give this a spin once merged

@machi1990
Copy link

lgtm

@skeeey
Copy link
Contributor Author

skeeey commented Jun 28, 2024

update the sdk-go to remove the version annotation dependence

Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clyang82
Copy link
Contributor

clyang82 commented Jul 1, 2024

/ok-to-test

@clyang82 clyang82 merged commit 28d727f into openshift-online:main Jul 1, 2024
5 checks passed
@skeeey skeeey deleted the ver branch July 1, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants