default orphan delete option for read only update strategy. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @clyang82 |
|
/ok-to-test |
clyang82
reviewed
Sep 11, 2024
pkg/api/resource_types.go
Outdated
| } | ||
| } | ||
|
|
||
| if len(deleteOption) != 0 { |
There was a problem hiding this comment.
that means even if the update_strategy is readonly, the delete_option still can be configured. the requirement is if the update_strategy is readonly, the delete_option is orphan. and cannot be configured.
There was a problem hiding this comment.
updated this to force deletio option to Orphan when update strategy is ReadOnly.
Signed-off-by: morvencao <[email protected]>
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_delete_option
branch
from
8491d18
to
348f703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://issues.redhat.com/browse/ACM-13118