Skip to content

make it possible to have separate serialization API types and the client to access them #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 3, 2025

This will allow us to split the definition of API types from API client. While doing this, it is worthwhile to continue making it possible for those who wish to generate their own client it its entirety. This is useful for cases where we create a model and choose not to create a client for it. If we don't do that, then it isn't useful and isn't needed.

remaining

  • add --verify argument to confirm generation up to date
  • extract some common types to avoid duplication.

@deads2k deads2k changed the title [WIP] add --generators argument to allow specifying which generators to run [wip] make it possible to have separate serialization API types and the client to access them Mar 26, 2025
@deads2k deads2k changed the title [wip] make it possible to have separate serialization API types and the client to access them make it possible to have separate serialization API types and the client to access them May 20, 2025
@deads2k
Copy link
Contributor Author

deads2k commented May 20, 2025

/test all

@deads2k deads2k force-pushed the select-generator branch from ba2daee to 0cf699c Compare May 27, 2025 18:28
Copy link

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k
Once this PR has been reviewed and has the lgtm label, please assign vkareh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant