[WIP] ARO-16258: Add tracing package with sharable code that configures tracing provider #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vu Dinh <[email protected]>
dinhxuanvu
changed the title
dinhxuanvu
commented
Mar 5, 2025
dinhxuanvu
changed the title
dinhxuanvu
force-pushed
the
tracing-pkg
branch
2 times, most recently
from
f7f9661 to
8bcd340
Compare
|
@simonpasquier @frzifus Unless there are any other comments, seeking for a lgtm here. Thanks :) |
dinhxuanvu
changed the title
|
@gdbranco Would like to ask for your help getting this PR merge. Thanks |
The tracing package contains sharable common code that configure tracing provider. The package then can be vendored into other projects/components that need to set up OpenTelemetry tracing. Signed-off-by: Vu Dinh <[email protected]>
gdbranco
reviewed
Mar 26, 2025
Delegate the shutdown func setup to the users in order to enable them to set desirable timeout and other customization if needed. Signed-off-by: Vu Dinh <[email protected]>
|
We are holding this PR for now as there is another PR from Simon on CS that will no longer use env variables from autoexport library. I may need to change this PR to follow that pattern. |
dinhxuanvu
changed the title
gdbranco
approved these changes
Apr 3, 2025
dinhxuanvu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracing package contains sharable common code that configure tracing
provider. The package then can be vendored into other projects/components
that need to set up OpenTelemetry tracing.
Signed-off-by: Vu Dinh [email protected]