e2e: add more log of where the github push going

we would not be able to see the github push url in the logs, this is
to help for failures.

test/github_incoming_test.go

@@ -87,14 +87,14 @@ func verifyIncomingWebhook(t *testing.T, randomedString string, entries map[stri
 	targetRefName := fmt.Sprintf("refs/heads/%s", randomedString)
 
 	title := "TestGithubAppIncoming - " + randomedString
-	sha, err := tgithub.PushFilesToRef(ctx, ghprovider.Client, title,
+	sha, vref, err := tgithub.PushFilesToRef(ctx, ghprovider.Client, title,
 		repoinfo.GetDefaultBranch(),
 		targetRefName,
 		opts.Organization,
 		opts.Repo,
 		entries)
 	assert.NilError(t, err)
-	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to branch %s", sha, targetRefName)
+	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to branch %s", sha, vref.GetURL())
 
 	url := fmt.Sprintf("%s/incoming?repository=%s&branch=%s&pipelinerun=%s&secret=%s", opts.ControllerURL,
 		randomedString, randomedString, "pipelinerun-incoming", incomingSecreteValue)

test/github_pullrequest_concurrency_test.go

@@ -69,10 +69,10 @@ func TestGithubPullRequestConcurrency(t *testing.T) {
 	targetRefName := fmt.Sprintf("refs/heads/%s",
 		names.SimpleNameGenerator.RestrictLengthWithRandomSuffix("pac-e2e-test"))
 
-	sha, err := tgithub.PushFilesToRef(ctx, ghcnx.Client, logmsg, repoinfo.GetDefaultBranch(), targetRefName,
+	sha, vref, err := tgithub.PushFilesToRef(ctx, ghcnx.Client, logmsg, repoinfo.GetDefaultBranch(), targetRefName,
 		opts.Organization, opts.Repo, entries)
 	assert.NilError(t, err)
-	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to %s", sha, targetRefName)
+	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to %s", sha, vref.GetURL())
 
 	prNumber, err := tgithub.PRCreate(ctx, runcnx, ghcnx, opts.Organization,
 		opts.Repo, targetRefName, repoinfo.GetDefaultBranch(), logmsg)

test/github_scope_token_to_list_of_private_public_repos_test.go

@@ -149,9 +149,9 @@ func verifyGHTokenScope(t *testing.T, remoteTaskURL, remoteTaskName string, data
 	targetRefName := fmt.Sprintf("refs/heads/%s",
 		names.SimpleNameGenerator.RestrictLengthWithRandomSuffix("pac-e2e-test"))
 
-	sha, err := tgithub.PushFilesToRef(ctx, ghcnx.Client, "TestPullRequestRemoteAnnotations - "+targetRefName, repoinfo.GetDefaultBranch(), targetRefName, opts.Organization, opts.Repo, entries)
+	sha, vref, err := tgithub.PushFilesToRef(ctx, ghcnx.Client, "TestPullRequestRemoteAnnotations - "+targetRefName, repoinfo.GetDefaultBranch(), targetRefName, opts.Organization, opts.Repo, entries)
 	assert.NilError(t, err)
-	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to %s", sha, targetRefName)
+	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to %s", sha, vref.GetURL())
 
 	title := "TestPullRequestRemoteAnnotations - " + targetRefName
 	number, err := tgithub.PRCreate(ctx, runcnx, ghcnx, opts.Organization, opts.Repo, targetRefName, repoinfo.GetDefaultBranch(), title)

test/github_tkn_pac_cli_test.go

@@ -88,9 +88,9 @@ spec:
 	targetRefName := fmt.Sprintf("refs/heads/%s",
 		names.SimpleNameGenerator.RestrictLengthWithRandomSuffix("pac-e2e-test"))
 
-	sha, err := tgithub.PushFilesToRef(ctx, ghprovider.Client, "TestPacCli - "+targetRefName, repoinfo.GetDefaultBranch(), targetRefName, opts.Organization, opts.Repo, entries)
+	sha, vref, err := tgithub.PushFilesToRef(ctx, ghprovider.Client, "TestPacCli - "+targetRefName, repoinfo.GetDefaultBranch(), targetRefName, opts.Organization, opts.Repo, entries)
 	assert.NilError(t, err)
-	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to %s", sha, targetRefName)
+	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to %s", sha, vref.GetURL())
 
 	title := "TestPacCli - " + targetRefName
 	number, err := tgithub.PRCreate(ctx, runcnx, ghprovider, opts.Organization, opts.Repo, targetRefName, repoinfo.GetDefaultBranch(), title)

test/pkg/github/pr.go

@@ -18,10 +18,10 @@ import (
 	"gotest.tools/v3/assert"
 )
 
-func PushFilesToRef(ctx context.Context, client *github.Client, commitMessage, baseBranch, targetRef, owner, repo string, files map[string]string) (string, error) {
+func PushFilesToRef(ctx context.Context, client *github.Client, commitMessage, baseBranch, targetRef, owner, repo string, files map[string]string) (string, *github.Reference, error) {
 	maintree, _, err := client.Git.GetTree(ctx, owner, repo, baseBranch, false)
 	if err != nil {
-		return "", fmt.Errorf("error getting tree: %w", err)
+		return "", nil, fmt.Errorf("error getting tree: %w", err)
 	}
 	mainSha := maintree.GetSHA()
 	entries := []*github.TreeEntry{}
@@ -34,7 +34,7 @@ func PushFilesToRef(ctx context.Context, client *github.Client, commitMessage, b
 			Encoding: &encoding,
 		})
 		if err != nil {
-			return "", fmt.Errorf("error creating blobs: %w", err)
+			return "", nil, fmt.Errorf("error creating blobs: %w", err)
 		}
 		sha := blob.GetSHA()
 
@@ -49,7 +49,7 @@ func PushFilesToRef(ctx context.Context, client *github.Client, commitMessage, b
 
 	tree, _, err := client.Git.CreateTree(ctx, owner, repo, mainSha, entries)
 	if err != nil {
-		return "", err
+		return "", nil, err
 	}
 
 	commitAuthor := "OpenShift Pipelines E2E test"
@@ -68,7 +68,7 @@ func PushFilesToRef(ctx context.Context, client *github.Client, commitMessage, b
 		},
 	}, &github.CreateCommitOptions{})
 	if err != nil {
-		return "", err
+		return "", nil, err
 	}
 
 	ref := &github.Reference{
@@ -77,12 +77,12 @@ func PushFilesToRef(ctx context.Context, client *github.Client, commitMessage, b
 			SHA: commit.SHA,
 		},
 	}
-	_, _, err = client.Git.CreateRef(ctx, owner, repo, ref)
+	vref, _, err := client.Git.CreateRef(ctx, owner, repo, ref)
 	if err != nil {
-		return "", err
+		return "", nil, err
 	}
 
-	return commit.GetSHA(), nil
+	return commit.GetSHA(), vref, nil
 }
 
 func PRCreate(ctx context.Context, cs *params.Run, ghcnx *ghprovider.Provider, owner, repo, targetRef, defaultBranch, title string) (int, error) {
@@ -129,11 +129,10 @@ func RunPullRequest(ctx context.Context, t *testing.T, label string, yamlFiles [
 	targetRefName := fmt.Sprintf("refs/heads/%s",
 		names.SimpleNameGenerator.RestrictLengthWithRandomSuffix("pac-e2e-test"))
 
-	sha, err := PushFilesToRef(ctx, ghcnx.Client, logmsg, repoinfo.GetDefaultBranch(), targetRefName,
+	sha, vref, err := PushFilesToRef(ctx, ghcnx.Client, logmsg, repoinfo.GetDefaultBranch(), targetRefName,
 		opts.Organization, opts.Repo, entries)
 	assert.NilError(t, err)
-	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to %s", sha, targetRefName)
-
+	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to %s", sha, vref.GetURL())
 	number, err := PRCreate(ctx, runcnx, ghcnx, opts.Organization,
 		opts.Repo, targetRefName, repoinfo.GetDefaultBranch(), logmsg)
 	assert.NilError(t, err)
@@ -182,8 +181,8 @@ func RunPushRequest(ctx context.Context, t *testing.T, label string, yamlFiles [
 	assert.NilError(t, err)
 
 	targetRefName := fmt.Sprintf("refs/heads/%s", targetBranch)
-	sha, err := PushFilesToRef(ctx, ghcnx.Client, logmsg, repoinfo.GetDefaultBranch(), targetRefName, opts.Organization, opts.Repo, entries)
-	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to %s", sha, targetRefName)
+	sha, vref, err := PushFilesToRef(ctx, ghcnx.Client, logmsg, repoinfo.GetDefaultBranch(), targetRefName, opts.Organization, opts.Repo, entries)
+	runcnx.Clients.Log.Infof("Commit %s has been created and pushed to %s", sha, vref.GetURL())
 	assert.NilError(t, err)
 
 	sopt := wait.SuccessOpt{