Skip to content

Commit

Permalink
feat: add matrix provider to e2e test concurrency
Browse files Browse the repository at this point in the history
This change updates the GitHub Actions workflow to include the provider
in the concurrency group for e2e tests. This ensures that tests are
properly grouped and managed based on the provider, preventing conflicts
and improving test reliability.

Fix a backslash missing
  • Loading branch information
chmouel committed Dec 18, 2024
1 parent 6a1e996 commit 85d3213
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/kind-e2e-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
jobs:
e2e-tests:
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: ${{ github.workflow }}-${{ matrix.provider }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
name: e2e tests
runs-on: ubuntu-latest
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
- name: Run E2E Tests on pull_request
if: ${{ github.event_name != 'schedule' }}
run: |
./hack/gh-workflow-ci.sh run_e2e_tests
./hack/gh-workflow-ci.sh run_e2e_tests \
${{ matrix.provider }} \
"${{ secrets.BITBUCKET_CLOUD_TOKEN }}" \
"${{ secrets.WEBHOOK_SECRET }}" \
Expand All @@ -98,7 +98,7 @@ jobs:
if: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}
run: |
export NIGHTLY_E2E_TEST="true"
./hack/gh-workflow-ci.sh run_e2e_tests
./hack/gh-workflow-ci.sh run_e2e_tests \
${{ matrix.provider }} \
"${{ secrets.BITBUCKET_CLOUD_TOKEN }}" \
"${{ secrets.WEBHOOK_SECRET }}" \
Expand Down

0 comments on commit 85d3213

Please sign in to comment.