Skip to content

Commit

Permalink
Use old async timer chan for e2e tests
Browse files Browse the repository at this point in the history
We are getting some flakyness with tests crashing on time.Sleep.
I am guessing it's a go1.23 change that is causing this, see:

https://go.dev/wiki/Go123Timer

try to use the old async timer chan to see if it fixes the issue.
  • Loading branch information
chmouel committed Dec 9, 2024
1 parent 0315a46 commit c41ece2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ test-e2e-cleanup: ## cleanup test e2e namespace/pr left open

.PHONY: test-e2e
test-e2e: test-e2e-cleanup ## run e2e tests
@go test $(GO_TEST_FLAGS) -timeout $(TIMEOUT_E2E) -failfast -count=1 -tags=e2e $(GO_TEST_FLAGS) ./test
@env GODEBUG=asynctimerchan=1 \
go test $(GO_TEST_FLAGS) -timeout $(TIMEOUT_E2E) -failfast -count=1 -tags=e2e $(GO_TEST_FLAGS) ./test

.PHONY: html-coverage
html-coverage: ## generate html coverage
Expand Down

0 comments on commit c41ece2

Please sign in to comment.