-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix message when the repository cannot be matched #1361
Conversation
* Reference the repository CR in the message instead of namespace. * Remove deprecated message related to access token.
@savitaashture We can continue our conversation here if needed. |
Codecov Report
@@ Coverage Diff @@
## main #1361 +/- ##
==========================================
+ Coverage 60.72% 60.95% +0.23%
==========================================
Files 136 136
Lines 9914 9924 +10
==========================================
+ Hits 6020 6049 +29
+ Misses 3411 3392 -19
Partials 483 483
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Roming22 what do you mean by
this is needed for github webhook and other vcs that is not github apps |
@chmouel I would think that the issue would be raised later on in the process, most likely when calling |
ah yeah right we used to set status and needed to make sure we had a token for that on github webhook but since we are only a logging now it good for cleanup, this is a gtg, but we have a CI breakage atm so let's merge this when the breakage is fixed |
cb88d0e
to
7260744
Compare
Changes
The current error message appears to be confusing for users. They try to look into namespace issues instead of looking for a missing or a misconfigured Repository CR.
Submitter Checklist
make test
before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and dopre-commit install
in the root of this repo).make lint
before submitting a PR. The markdownlint error can get usually fixed by runningmake fix-markdownlint
(make sure it's installed first)