Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch matching when there is a slashes in the base branch name #1363

Conversation

savitaashture
Copy link
Member

Changes

Steps:

  1. have a branch name like pac/test/111/main in your project repo
  2. in Pipelinerun
    pipelinesascode.tekton.dev/on-event: "[pull_request, push]"
    pipelinesascode.tekton.dev/on-target-branch: "[pac/test/111/main]"
  1. Create pull request runs CI
  2. Merging PR don't run CI

Submitter Checklist

  • ♽ Run make test before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and do pre-commit install in the root of this repo).
  • ✨ We heavily rely on linters to get our code clean and consistent, please ensure that you have run make lint before submitting a PR. The markdownlint error can get usually fixed by running make fix-markdownlint (make sure it's installed first)
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1363 (51a453c) into main (89c385b) will increase coverage by 0.29%.
Report is 8 commits behind head on main.
The diff coverage is 86.76%.

@@            Coverage Diff             @@
##             main    #1363      +/-   ##
==========================================
+ Coverage   60.43%   60.73%   +0.29%     
==========================================
  Files         135      136       +1     
  Lines        9796     9916     +120     
==========================================
+ Hits         5920     6022     +102     
- Misses       3394     3411      +17     
- Partials      482      483       +1     
Files Changed Coverage Δ
pkg/provider/gitea/gitea.go 6.69% <0.00%> (-0.04%) ⬇️
pkg/provider/bitbucketcloud/bitbucket.go 71.29% <33.33%> (-0.69%) ⬇️
pkg/provider/bitbucketserver/bitbucketserver.go 77.08% <33.33%> (-0.82%) ⬇️
pkg/provider/gitlab/gitlab.go 71.17% <33.33%> (-0.65%) ⬇️
pkg/reconciler/reconciler.go 21.38% <50.00%> (ø)
pkg/provider/gitea/acl.go 74.79% <76.19%> (+0.40%) ⬆️
pkg/provider/github/acl.go 86.06% <89.18%> (+0.78%) ⬆️
pkg/policy/policy.go 92.30% <92.30%> (ø)
pkg/provider/github/detect.go 92.30% <94.59%> (+0.37%) ⬆️
pkg/matcher/annotation_matcher.go 95.42% <100.00%> (+2.09%) ⬆️
... and 4 more

@savitaashture
Copy link
Member Author

/retest

@piyush-garg piyush-garg merged commit 2eab30c into openshift-pipelines:main Aug 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants