-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source repo url information to standard parameters #1385
Add source repo url information to standard parameters #1385
Conversation
0e0d217
to
ce6595f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
=======================================
Coverage 60.97% 60.97%
=======================================
Files 136 136
Lines 9934 9935 +1
=======================================
+ Hits 6057 6058 +1
Misses 3392 3392
Partials 485 485
☔ View full report in Codecov by Sentry. |
what happen on push ? should we have the same as target_url like we had on target_branch? and let's make sure this would be documented with a test for it (push scenario). |
Yes we do same like target_branch I mean source and target URLs are same https://github.com/openshift-pipelines/pipelines-as-code/blob/main/pkg/provider/github/parse_payload.go#L246-L247 Actually we don't get the info of source URL directly in push i searched in Github docs Or am i missing something here 🤔 Alternative way: I did print push payload body https://gist.github.com/savitaashture/e1013de246b201ece565a86d7da96531 we get the data in bits of pieces we need to collect those in order to provide info of
You mean here https://pipelinesascode.com/docs/guide/authoringprs/#authoring-pipelineruns-in-tekton-directory we need to add a clarification for those standard parameters or push and pull_request
You mean e2e ? |
19cde72
to
e7fefce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some comments
e7fefce
to
0f0f600
Compare
Users can now use source_repo_url in pipelinerun template to get the information from which forked repo the event (Pull Request / Push) is coming from Signed-off-by: Savita Ashture <[email protected]>
0f0f600
to
85881f2
Compare
Users can now use
source_repo_url
in pipelinerun template to get the information from which forked repo the event (Pull Request / Push) is coming fromEx:
Signed-off-by: Savita Ashture [email protected]"
Changes
Submitter Checklist
make test
before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and dopre-commit install
in the root of this repo).make lint
before submitting a PR. The markdownlint error can get usually fixed by runningmake fix-markdownlint
(make sure it's installed first)