Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1471

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Oct 16, 2023

Update all deps (no pinned deps)

bitbucket has a change in their calls:

GetContent_11(v.projectKey, runevent.Repository, path, localVarOptionals)

become

GetRawContent(v.projectKey, runevent.Repository, path, localVarOptionals)

gitlab changed some of their struct to a proper type and deprecated GetMergeRequestChanges to ListMergeRequestDiff (filled as TODO in #1470)

Changes

Submitter Checklist

  • 📝 A good commit message is important for other reviewers to understand the context of your change. Please refer to How to Write a Git Commit Message for more details how to write beautiful commit messages. We rather have the commit message in the PR body and the commit message instead of an external website.
  • ♽ Run make test before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and do pre-commit install in the root of this repo).
  • ✨ We heavily rely on linters to get our code clean and consistent, please ensure that you have run make lint before submitting a PR. The markdownlint error can get usually fixed by running make fix-markdownlint (make sure it's installed first)
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c0fd155) 61.62% compared to head (3094543) 61.65%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
+ Coverage   61.62%   61.65%   +0.03%     
==========================================
  Files         136      136              
  Lines       10255    10258       +3     
==========================================
+ Hits         6320     6325       +5     
+ Misses       3424     3422       -2     
  Partials      511      511              
Files Coverage Δ
pkg/cli/status/status.go 92.30% <ø> (ø)
pkg/cmd/tknpac/bootstrap/github.go 91.42% <100.00%> (ø)
pkg/cmd/tknpac/bootstrap/install.go 0.00% <ø> (ø)
pkg/cmd/tknpac/bootstrap/kubestuff.go 16.66% <ø> (ø)
pkg/cmd/tknpac/info/install.go 51.19% <ø> (ø)
pkg/kubeinteraction/events.go 0.00% <ø> (ø)
pkg/kubeinteraction/pod_logs.go 0.00% <ø> (ø)
pkg/provider/bitbucketserver/acl.go 59.45% <100.00%> (ø)
pkg/provider/bitbucketserver/bitbucketserver.go 77.08% <100.00%> (ø)
pkg/provider/github/acl.go 80.09% <ø> (ø)
... and 9 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bitbucket has a change in their calls:

GetContent_11(v.projectKey, runevent.Repository, path, localVarOptionals)
becomes:
GetRawContent(v.projectKey, runevent.Repository, path, localVarOptionals)

bitbucket has a change as well on how to pass files to create..

gitlab changed some of their struct to a proper type and deprecated
GetMergeRequestChanges to ListMergeRequestDiff (filled as TODO in openshift-pipelines#1470)

Signed-off-by: Chmouel Boudjnah <[email protected]>
@piyush-garg piyush-garg merged commit 8c59966 into openshift-pipelines:main Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants