Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TKN_BINARY_URL in Makefile #1498

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Set TKN_BINARY_URL in Makefile #1498

merged 1 commit into from
Nov 13, 2023

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Nov 13, 2023

To make it easier to override the TKN_BINARY_URL, set it in the Makefile

Changes

Submitter Checklist

  • 📝 A good commit message is important for other reviewers to understand the context of your change. Please refer to How to Write a Git Commit Message for more details how to write beautiful commit messages. We rather have the commit message in the PR body and the commit message instead of an external website.
  • ♽ Run make test before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and do pre-commit install in the root of this repo).
  • ✨ We heavily rely on linters to get our code clean and consistent, please ensure that you have run make lint before submitting a PR. The markdownlint error can get usually fixed by running make fix-markdownlint (make sure it's installed first)
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

To make it easier to override the TKN_BINARY_URL, set it in the Makefile
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 79f228c
Status: ✅  Deploy successful!
Preview URL: https://0561e6a8.pipelines-as-code.pages.dev
Branch Preview URL: https://set-binary-url.pipelines-as-code.pages.dev

View logs

@chmouel chmouel merged commit 27db417 into main Nov 13, 2023
4 checks passed
@chmouel chmouel deleted the set-binary-url branch November 13, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant