Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log for TestGHPullRequestConcurrencyMultiplePR #1713

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Jun 12, 2024

Try to add some debugs for the tests and more logs collected by namespaces.

Related to bug #1691

Changes

Submitter Checklist

  • 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

  • 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.65%. Comparing base (17aae4b) to head (c89ee38).
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/pipelineascode/concurrency.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1713   +/-   ##
=======================================
  Coverage   64.65%   64.65%           
=======================================
  Files         145      145           
  Lines       11192    11195    +3     
=======================================
+ Hits         7236     7238    +2     
  Misses       3428     3428           
- Partials      528      529    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chmouel chmouel force-pushed the issue-1691-e2e-test-testgithubsecondpullrequestconcurrencymulti branch from 3f61016 to 0d9f01e Compare June 12, 2024 11:55
Try to add some debugs for the tests and more logs collected by
namespaces.

Related to bug openshift-pipelines#1691

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel chmouel force-pushed the issue-1691-e2e-test-testgithubsecondpullrequestconcurrencymulti branch from 0d9f01e to c89ee38 Compare June 12, 2024 12:35
@chmouel chmouel merged commit b466ac7 into openshift-pipelines:main Jun 12, 2024
4 checks passed
@chmouel chmouel deleted the issue-1691-e2e-test-testgithubsecondpullrequestconcurrencymulti branch June 12, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant