Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new subcommand auth in tkn-pac CLI #1736

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zakisk
Copy link
Contributor

@zakisk zakisk commented Jul 10, 2024

Adds new subcommand to authenticate user with git providers and stores those token locally for further use of tkn-pac

fix #680
https://issues.redhat.com/browse/SRVKP-5548

@zakisk zakisk requested a review from piyush-garg July 10, 2024 09:39
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 18.50649% with 251 lines in your changes missing coverage. Please review.

Project coverage is 64.03%. Comparing base (2d465fe) to head (ecb34fd).

Files Patch % Lines
pkg/cmd/tknpac/auth/login.go 0.00% 135 Missing ⚠️
pkg/cmd/tknpac/auth/keyring.go 0.00% 54 Missing ⚠️
pkg/cmd/tknpac/auth/login_flow.go 54.80% 41 Missing and 6 partials ⚠️
pkg/cmd/tknpac/auth/root.go 0.00% 14 Missing ⚠️
pkg/cmd/tknpac/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1736      +/-   ##
==========================================
- Coverage   65.11%   64.03%   -1.09%     
==========================================
  Files         174      178       +4     
  Lines       13137    13445     +308     
==========================================
+ Hits         8554     8609      +55     
- Misses       4018     4265     +247     
- Partials      565      571       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zakisk
Copy link
Contributor Author

zakisk commented Jul 11, 2024

@savitaashture have a look at this.

Zaki Shaikh added 3 commits August 20, 2024 15:52
Adds new subcommand to authenticate user with git providers
and stores those token locally for further use of tkn-pac

fix openshift-pipelines#680
https://issues.redhat.com/browse/SRVKP-5548

Signed-off-by: Zaki Shaikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Create github token from tkn-pac
1 participant