Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Resolver #1761

Closed
wants to merge 1 commit into from
Closed

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Sep 10, 2024

This will refactor resolver to work with multiple edge case scenarios

Changes

Submitter Checklist

  • 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

  • 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

This will refactor resolver to work with multiple edge case scenarios

Co-authored-by: Chmouel Boudjnah <[email protected]>
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 67.13287% with 47 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (6f16e11) to head (f881490).

Files with missing lines Patch % Lines
pkg/resolve/remote.go 52.04% 37 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1761      +/-   ##
==========================================
- Coverage   65.08%   64.57%   -0.52%     
==========================================
  Files         174      174              
  Lines       13167    13169       +2     
==========================================
- Hits         8570     8504      -66     
- Misses       4029     4093      +64     
- Partials      568      572       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chmouel chmouel closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants