update go dependences to latest #1815
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all go dependences to latest pin to go 1.22 for downstream rht pin some dependencies due of 1.23 conflict
Update pre-commit to the latest version
update vale sync rules
chmouel
force-pushed
the
switch-to-latest
branch
from
50f70de
to
11828e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1815 +/- ##
=======================================
Coverage 65.17% 65.17%
=======================================
Files 175 175
Lines 13529 13529
=======================================
Hits 8817 8817
Misses 4125 4125
Partials 587 587 ☔ View full report in Codecov by Sentry. |
we can remove the pinned dependencies: knative.dev/eventing to v0.39.0 k8s.io/kube-openapi v0.0.0-20230515203736-54b630e78af5 Signed-off-by: Chmouel Boudjnah <[email protected]>
|
weird thing happening with e2e getting this permission denied error Log Error``` 2024-11-07T11:25:47.021022617Z stdout F {"level":"info","ts":"2024-11-07T11:25:47.020Z","logger":"pipelinesascode","caller":"v2/configurator_configmap.go:104","msg":"Adding Watcher on ConfigMap pac-config-logging for logs","commit":"11c8a7a"} 2024-11-07T11:25:47.021343226Z stdout F {"level":"info","ts":"2024-11-07T11:25:47.021Z","logger":"pipelinesascode","caller":"v2/main.go:225","msg":"ConfigMap watcher is enabled","commit":"11c8a7a"} 2024-11-07T11:25:47.022136387Z stderr F W1107 11:25:47.022062 1 reflector.go:561] k8s.io/[email protected]/tools/cache/reflector.go:243: failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:pipelines-as-code:pipelines-as-code-controller" cannot list resource "configmaps" in API group "" at the cluster scope 2024-11-07T11:25:47.022150834Z stderr F E1107 11:25:47.022098 1 reflector.go:158] "Unhandled Error" err="k8s.io/[email protected]/tools/cache/reflector.go:243: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps is forbidden: User \"system:serviceaccount:pipelines-as-code:pipelines-as-code-controller\" cannot list resource \"configmaps\" in API group \"\" at the cluster scope" logger="UnhandledError" 2024-11-07T11:25:47.908767908Z stderr F W1107 11:25:47.908669 1 reflector.go:561] k8s.io/[email protected]/tools/cache/reflector.go:243: failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:pipelines-as-code:pipelines-as-code-controller" cannot list resource "configmaps" in API group "" at the cluster scope 2024-11-07T11:25:47.908784479Z stderr F E1107 11:25:47.908717 1 reflector.go:158] "Unhandled Error" err="k8s.io/[email protected]/tools/cache/reflector.go:243: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps is forbidden: User \"system:serviceaccount:pipelines-as-code:pipelines-as-code-controller\" cannot list resource \"configmaps\" in API group \"\" at the cluster scope" logger="UnhandledError" 2024-11-07T11:25:49.949503247Z stderr F W1107 11:25:49.949364 1 reflector.go:561] k8s.io/[email protected]/tools/cache/reflector.go:243: failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:pipelines-as-code:pipelines-as-code-controller" cannot list resource "configmaps" in API group "" at the cluster scope 2024-11-07T11:25:49.949525248Z stderr F E1107 11:25:49.949418 1 reflector.go:158] "Unhandled Error" err="k8s.io/[email protected]/tools/cache/reflector.go:243: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps is forbidden: User \"system:serviceaccount:pipelines-as-code:pipelines-as-code-controller\" cannot list resource \"configmaps\" in API group \"\" at the cluster scope" logger="UnhandledError" 2024-11-07T11:25:54.811640417Z stderr F W1107 11:25:54.811540 1 reflector.go:561] k8s.io/[email protected]/tools/cache/reflector.go:243: failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:pipelines-as-code:pipelines-as-code-controller" cannot list resource "configmaps" in API group "" at the cluster scope 2024-11-07T11:25:54.811657248Z stderr F E1107 11:25:54.811579 1 reflector.go:158] "Unhandled Error" err="k8s.io/[email protected]/tools/cache/reflector.go:243: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps is forbidden: User \"system:serviceaccount:pipelines-as-code:pipelines-as-code-controller\" cannot list resource \"configmaps\" in API group \"\" at the cluster scope" logger="UnhandledError" 2024-11-07T11:26:01.794770673Z stderr F W1107 11:26:01.794673 1 reflector.go:561] k8s.io/[email protected]/tools/cache/reflector.go:243: failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:pipelines-as-code:pipelines-as-code-controller" cannot list resource "configmaps" in API group "" at the cluster scope 2024-11-07T11:26:01.794798786Z stderr F E1107 11:26:01.794721 1 reflector.go:158] "Unhandled Error" err="k8s.io/[email protected]/tools/cache/reflector.go:243: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps is forbidden: User \"system:serviceaccount:pipelines-as-code:pipelines-as-code-controller\" cannot list resource \"configmaps\" in API group \"\" at the cluster scope" logger="UnhandledError" 2024-11-07T11:26:20.179519206Z stderr F W1107 11:26:20.179430 1 reflector.go:561] k8s.io/[email protected]/tools/cache/reflector.go:243: failed to list *v1.ConfigMap: configmaps is forbidden: User "system:serviceaccount:pipelines-as-code:pipelines-as-code-controller" cannot list resource "configmaps" in API group "" at the cluster scope 2024-11-07T11:26:20.179546112Z stderr F E1107 11:26:20.179483 1 reflector.go:158] "Unhandled Error" err="k8s.io/[email protected]/tools/cache/reflector.go:243: Failed to watch *v1.ConfigMap: failed to list *v1.ConfigMap: configmaps is forbidden: User \"system:serviceaccount:pipelines-as-code:pipelines-as-code-controller\" cannot list resource \"configmaps\" in API group \"\" at the cluster scope" logger="UnhandledError" 2024-11-07T11:26:31.814603678Z stdout F {"level":"fatal","ts":"2024-11-07T11:26:31.814Z","logger":"pipelinesascode","caller":"v2/main.go:284","msg":"Failed to start configuration manager","commit":"11c8a7a","error":"error waiting for ConfigMap informer to sync","stacktrace":"knative.dev/eventing/pkg/adapter/v2.MainWithInformers\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:284\nknative.dev/eventing/pkg/adapter/v2.MainWithEnv\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:163\nknative.dev/eventing/pkg/adapter/v2.MainWithContext\n\tknative.dev/[email protected]/pkg/adapter/v2/main.go:138\nmain.main\n\tgithub.com/openshift-pipelines/pipelines-as-code/cmd/pipelines-as-code-controller/main.go:48\nruntime.main\n\truntime/proc.go:272"} ``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).