-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for matching PipelineRuns to Pull Request labels #1854
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1854 +/- ##
==========================================
- Coverage 65.74% 65.64% -0.11%
==========================================
Files 178 178
Lines 13840 13889 +49
==========================================
+ Hits 9099 9117 +18
- Misses 4126 4148 +22
- Partials 615 624 +9 ☔ View full report in Codecov by Sentry. |
b734835
to
d1cff10
Compare
/test go-testing |
15a87e1
to
9acf54c
Compare
9acf54c
to
64d697e
Compare
4d44daf
to
cb6e218
Compare
/test go-testing |
Yeah I need to update the video😅 it's called pull_requests_labels now since can only apply there , see the doc and e2e |
81decdd
to
b9cff91
Compare
/retest |
Implement annotation-based PipelineRun to label matching functionality: - Add `pipelinesascode.tekton.dev/on-label` annotation for label-based PipelineRun triggers - Support label matching on GitHub, Gitea, and GitLab providers - Implement immediate PipelineRun triggering when labels are added - Enable re-triggering of PipelineRuns on commit updates with existing labels - Provide access to Pull Request labels via `{{ pull_request_labels }}` dynamic variable Supported providers: - GitHub - Gitea - GitLab Limitations: - Not supported on Bitbucket Cloud and Bitbucket Server Signed-off-by: Chmouel Boudjnah <[email protected]>
b9cff91
to
4ded853
Compare
@chmouel now I see
|
Is it a question ?@zakisk |
@chmouel No, just saying that I am able to print labels with |
Implement annotation-based PipelineRun to label matching functionality: - Add `pipelinesascode.tekton.dev/on-label` annotation for label-based PipelineRun triggers - Support label matching on GitHub, Gitea, and GitLab providers - Implement immediate PipelineRun triggering when labels are added - Enable re-triggering of PipelineRuns on commit updates with existing labels - Provide access to Pull Request labels via `{{ pull_request_labels }}` dynamic variable Supported providers: - GitHub - Gitea - GitLab Limitations: - Not supported on Bitbucket Cloud and Bitbucket Server https://issues.redhat.com/browse/SRVKP-5950 Signed-off-by: Chmouel Boudjnah <[email protected]>
only add the support_matrix documentation tag, merging it due of @zakisk previous review |
Implement annotation-based PipelineRun label matching functionality:
pipelinesascode.tekton.dev/on-label
annotation for label-based PipelineRun triggers{{ pull_request_labels }}
dynamic variableSupported providers:
Limitations:
Demo:
2024-12-11.16-48-26.mp4
https://issues.redhat.com/browse/SRVKP-5950
Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).