fix: handle nil repo in GitHub event payloads #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
==========================================
- Coverage 65.74% 65.72% -0.03%
==========================================
Files 178 178
Lines 13836 13851 +15
==========================================
+ Hits 9097 9103 +6
- Misses 4124 4133 +9
Partials 615 615 ☔ View full report in Codecov by Sentry. |
chmouel
force-pushed
the
fix-crash-with-bad-payload
branch
from
a701846 to
8110393
Compare
vdemeester
approved these changes
Dec 19, 2024
vdemeester
force-pushed
the
fix-crash-with-bad-payload
branch
from
6924457 to
8230ae3
Compare
- Add logging for pipeline run creation and cancellation - Update wait options for pipeline run creation - Replace check run status check with pipeline run status check - Ensure proper handling of pipeline run cancellation status
- Introduced DEFAULT_GO_TEST_FLAGS for default test flags - Added comments for vendor and other targets - Removed redundant test-unit targets - Updated test-e2e to use DEFAULT_GO_TEST_FLAGS - Added gitlint target for commit message linting - Minor formatting and cleanup
chmouel
force-pushed
the
fix-crash-with-bad-payload
branch
from
8230ae3 to
7fe2797
Compare
We were getting a crash on the controller due to a nil pointer dereference when the repository was nil in the payload. This commit adds checks to ensure the repository is not nil before accessing its properties. TestSkippedEvent shows the issue but it wasn't detected that the controller was crashing and happily returned ok.
printing the whole log file is not useful, as it can be very long to scoll at times.
chmouel
force-pushed
the
fix-crash-with-bad-payload
branch
from
7fe2797 to
7bf19a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting a crash on the controller due to a nil pointer dereference
when the repository was nil in the payload. This commit adds checks to
ensure the repository is not nil before accessing its properties.
TestSkippedEvent shows the issue but it wasn't detected that the controller
was crashing and happily returned ok.
Signed-off-by: Chmouel Boudjnah [email protected]