Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting machineset using additional label flag to ignore 'infra' nodes. #147

Merged
merged 2 commits into from
May 17, 2022
Merged

Getting machineset using additional label flag to ignore 'infra' nodes. #147

merged 2 commits into from
May 17, 2022

Conversation

skordas
Copy link

@skordas skordas commented May 13, 2022

$title
Please check issue #145 for more information.

@skordas
Copy link
Author

skordas commented May 13, 2022

@paigerube14 ptal

@skordas
Copy link
Author

skordas commented May 13, 2022

/assign @paigerube14

@paigerube14
Copy link
Contributor

paigerube14 commented May 16, 2022

@skordas
I did a quick test on one of Sharada's clusters that already had infra and workload nodes configured and using the new label you had added I still get the whole list back. Looking at the labels. I do not see any easy way to figure out the machinesets that are workers vs infra/workload nodes. Think we need to keep looking

% oc get --no-headers machinesets -A -l machine.openshift.io/cluster-api-cluster
openshift-machine-api   infra-us-east-1a                               1     1                 2m13s
openshift-machine-api   infra-us-east-1b                               1     1                 2m13s
openshift-machine-api   infra-us-east-1c                               1     1                 2m13s
openshift-machine-api   svetsa-9323-baseline-5tx7k-worker-us-east-1a   24    24    24    24    43m
openshift-machine-api   svetsa-9323-baseline-5tx7k-worker-us-east-1b   24    24    24    24    43m
openshift-machine-api   svetsa-9323-baseline-5tx7k-worker-us-east-1c   24    24    24    24    43m
openshift-machine-api   svetsa-9323-baseline-5tx7k-worker-us-east-1d   24    24    24    24    43m
openshift-machine-api   svetsa-9323-baseline-5tx7k-worker-us-east-1f   24    24    24    24    43m
openshift-machine-api   workload-us-east-1a                            1     1                 2m12s

@paigerube14
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 16, 2022
@qiliRedHat
Copy link
Contributor

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paigerube14, qiliRedHat, skordas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8f5e89b into openshift-qe:cluster-workers-scaling May 17, 2022
@qiliRedHat
Copy link
Contributor

Tested with job https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/scale-ci/job/e2e-benchmarking-multibranch-pipeline/job/cluster-workers-scaling/714/console, infra machinesets are not scaled.

% oc get machinesets -A
NAMESPACE               NAME                               DESIRED   CURRENT   READY   AVAILABLE   AGE
openshift-machine-api   qili-az-d9sqx-infra-centralus1     1         1         1       1           153m
openshift-machine-api   qili-az-d9sqx-infra-centralus2     1         1         1       1           153m
openshift-machine-api   qili-az-d9sqx-infra-centralus3     1         1         1       1           153m
openshift-machine-api   qili-az-d9sqx-worker-centralus1    2         2                             4h31m
openshift-machine-api   qili-az-d9sqx-worker-centralus2    0         0                             4h31m
openshift-machine-api   qili-az-d9sqx-worker-centralus3    0         0                             4h31m
openshift-machine-api   qili-az-d9sqx-workload-centralus   1         1         1       1           153m

@qiliRedHat
Copy link
Contributor

@skordas @paigerube14 Not working on GCP, I opened #153 to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants