-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrent jobs with configmaps #87
base: master
Are you sure you want to change the base?
Concurrent jobs with configmaps #87
Conversation
@chaitanyaenr PTAL |
Adding enabling/disabling pbench during workload run.
adding @mffiedler |
Thanks for the PR @skordas, will test it out today. |
## Smoke test variables | ||
|
||
``` | ||
CONCURRENT_JOBS_NODE_COUNT=4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CONCURRENT_JOBS_NODE_COUNT, CONCURRENT_JOBS_MAXPODS, CONCURRENT_JOBS_POD_IMAGE, CONCURRENT_JOBS_STEPSIZE and CONCURRENT_JOBS_PAUSE vars are not being used by the workload.
number_of_concurrent_jobs: "{{ lookup('env', 'NUMBER_OF_CONCURRENT_JOBS')|default(300, true)|int }}" | ||
job_completion_poll_attempts: "{{ lookup('env', 'JOB_COMPLETION_POLL_ATTEMPTS')|default(360, true)|int }}" | ||
|
||
# Concurrent jobs smoke test workload specific parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CONCURRENT_JOBS_NODE_COUNT, CONCURRENT_JOBS_MAXPODS, CONCURRENT_JOBS_POD_IMAGE, CONCURRENT_JOBS_STEPSIZE and CONCURRENT_JOBS_PAUSE vars are not being used by the workload.
spec: | ||
containers: | ||
- name: busybox | ||
image: busybox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we parameterize the image instead of hard coding it please?
@skordas Tested the workload and it works fine, think we need to add the code to delete the objects created by the workload at the end of the run. |
Looks good to me so far. +1 to @chaitanyaenr comment - need to leave cluster in pre-test state. |
@skordas any update? |
…into concurrent_jobs_with_configmaps
Workload to run concurrent jobs with configmaps.
Inspired by issue: kubernetes/kubernetes#74412 (comment)