Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workloads for taints and tolerations #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wabouhamad
Copy link
Contributor

This is the initial workload commit for the Taints and Tolerations testcase:

    modified:   workloads/docs/README.md
new file:    workloads/docs/taints-tolerations.md
new file:    workloads/workloads/files/workload-taints-tolerations-script-cm.yml
new file:    workloads/workloads/taints-toleration.yaml
modified:  workloads/workloads/templates/workload-env.yml.j2
new file:    workloads/workloads/vars/taints-tolerations.yml

@wabouhamad
Copy link
Contributor Author

@mffiedler @chaitanyaenr PTAL

@@ -0,0 +1,131 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the file needs to be taints-tolerations.yml to match the README.


The Taints and Tolerations workload playbook is `workloads/taints-tolerations.yml` and will run the Taints and Tolerations workload on your cluster.

The Taints and Tolerations workload's purpose is to validate if the OpenShift cluster can deploy 130 hello-pods with memory and CPU requests per tainted worker node.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the number of pods, tainted nodes and cpu requests configurable so that it will work/scale for any sized cluster?

Copy link

@schituku schituku Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above will be moved as an enhancement/issue for addressing later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.


The Taints and Tolerations workload's purpose is to validate if the OpenShift cluster can deploy 130 hello-pods with memory and CPU requests per tainted worker node.

An OCP with 3 masters and 3 worker nodes is required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wabouhamad better to mention the min worker instance type required to run this workload in the docs since it uses cpu and memory requests. Thoughts?

Copy link
Member

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor nits. We can merge it in once they are resolved. Also lets squash the commits. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants