Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-1689: features: add ShortCertRotation #1977

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

API-1689: features: add ShortCertRotation #1977

wants to merge 1 commit into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Jul 30, 2024 •
edited
Loading

Enhancement proposal: openshift/enhancements#1670

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

Hello @vrutkovs! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the feature-short-cert-rotation branch from 670935b to 1b057be Compare August 6, 2024 08:45
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
@vrutkovs vrutkovs force-pushed the feature-short-cert-rotation branch from 1b057be to 05089ce Compare August 8, 2024 06:33
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 8, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2024
@vrutkovs vrutkovs changed the title features: add ShortCertRotation API-1689: features: add ShortCertRotation Aug 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2024 •
edited by openshift-ci bot
Loading

@vrutkovs: This pull request references API-1689 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 26, 2024
@vrutkovs vrutkovs marked this pull request as ready for review August 26, 2024 09:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2024
@vrutkovs
Copy link
Member Author

/retest

@vrutkovs
Copy link
Member Author

/test e2e-aws-ovn

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2024 •
edited by openshift-ci bot
Loading

@vrutkovs: This pull request references API-1689 which is a valid jira issue.

In response to this:

Enhancement proposal: openshift/enhancements#1670

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tkashem
tkashem reviewed Sep 3, 2024
View reviewed changes
features/features.go
@@ -610,4 +610,11 @@ var (
productScope(kubernetes).
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

FeatureShortCertRotation = newFeatureGate("ShortCertRotation").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is meant to be a CI only feature, then can we rename it to make it obvious, something like CIOnlyShortCertRotation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature will be tested in CI, but it may be used in manual testing. I don't mind renaming it though

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 3929a3d link true /test e2e-aws-ovn
ci/prow/e2e-gcp 3929a3d link false /test e2e-gcp
ci/prow/e2e-aws-ovn-techpreview 3929a3d link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkashem tkashem tkashem left review comments

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vrutkovs @openshift-ci-robot @tkashem @openshift-merge-robot