- 
                Notifications
    
You must be signed in to change notification settings  - Fork 577
 
CNTRLPLANE-311: adding auth config missing fields to API #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
           Hello @ShazaAldawamneh! Some important instructions when contributing to openshift/api:  | 
    
| 
           @ShazaAldawamneh: This pull request references CNTRLPLANE-311 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.  | 
    
        
          
                config/v1/tests/authentications.config.openshift.io/ExternalOIDCWithNewAuthConfigFields.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                config/v1/tests/authentications.config.openshift.io/ExternalOIDCWithUpstreamParity.yaml
          
            Show resolved
            Hide resolved
        
              
          
                config/v1/tests/authentications.config.openshift.io/ExternalOIDCWithNewAuthConfigFields.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                config/v1/tests/authentications.config.openshift.io/ExternalOIDCWithNewAuthConfigFields.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 
           /assign  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all of the CEL expression fields, can we also get a PR up against openshift/kubernetes similar to openshift/kubernetes#2353 to show that we are going to be adding admission time validation for the newly added CEL expression fields?
        
          
                config/v1/tests/authentications.config.openshift.io/ExternalOIDCWithUpstreamParity.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      Signed-off-by: Shaza Aldawamneh <[email protected]>
582db23    to
    f854a3d      
    Compare
  
    | 
           [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. 
Needs approval from an approver in each of these files:
 
      Approvers can indicate their approval by writing   | 
    
| 
           @ShazaAldawamneh: The following tests failed, say  
 Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.  | 
    
No description provided.