OCPBUGS-55649: Remove SetEIPForNLBIngressController feature gate

[rikatz]

This change removes the Feature gate SetEIPForNLBIngressController from the API.

The FG is not used anymore by cluster-ingress-operator and is not required to be part of the code anymore. The removal of CIO code happened on openshift/cluster-ingress-operator#1280

Additionally, the FG has been enabled by default since 4.18 and can be safely removed

[openshift-ci]

Hello @rikatz! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@rikatz: This pull request references Jira Issue OCPBUGS-55649, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change removes the Feature gate SetEIPForNLBIngressController from the API.

The FG is not used anymore by cluster-ingress-operator and is not required to be part of the code anymore. The removal of CIO code happened on openshift/cluster-ingress-operator#1280

Additionally, the FG has been enabled by default since 4.18 and can be safely removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rikatz]

/jira refresh

[openshift-ci-robot]

@rikatz: This pull request references Jira Issue OCPBUGS-55649, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rikatz]

/hold

Need to check and fix generated files

Will also wait for #2400 to merge

[everettraven]

@rikatz It looks like we still need to regenerate our set of generated files with this change. Please perform regeneration with make update and push the associated changes.

Thanks!

[rikatz]

@everettraven sure, I am waiting #2400 to be merged before I proceed with mine, as we are touching similar lines I want Greg's PR to go first!

Thanks!

[rikatz]

@everettraven now ready to go. I did a make update and the newly generated openapi scared me, so I am keeping it on a separate commit if we decide to drop it
/hold cancel

[JoelSpeed]

/lgtm

[openshift-ci-robot]

/test remaining-required

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed,everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[melvinjoseph86]

Launch cluster-bot with this PR and the functionality is still working well and EIP are set as expected.
'SetEIPForNLBIngressController' is now removed from the featuregates.config.openshift.io

mjoseph@mjoseph-mac Downloads % oc get  featuregate cluster -oyaml
apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
  annotations:
    include.release.openshift.io/self-managed-high-availability: "true"
  creationTimestamp: "2025-10-03T13:08:26Z"
  generation: 1
  name: cluster
  resourceVersion: "712"
  uid: 9ac03c5b-1ea9-426e-8b21-eb0809df63ee
spec: {}
status:
  featureGates:
  - disabled:
    - name: AWSClusterHostedDNS
    - name: AWSClusterHostedDNSInstall
    - name: AWSDedicatedHosts
    - name: AWSDualStackInstall
    - name: AWSServiceLBNetworkSecurityGroup
    - name: AutomatedEtcdBackup
    - name: AzureClusterHostedDNSInstall
    - name: AzureDedicatedHosts
    - name: AzureDualStackInstall
    - name: AzureMultiDisk
    - name: BootImageSkewEnforcement
    - name: BootcNodeManagement
    - name: CBORServingAndStorage
    - name: ClientsAllowCBOR
    - name: ClientsPreferCBOR
    - name: ClusterAPIInstall
    - name: ClusterAPIInstallIBMCloud
    - name: ClusterAPIMachineManagementVSphere
    - name: ClusterMonitoringConfig
    - name: ClusterVersionOperatorConfiguration
    - name: DNSNameResolver
    - name: DualReplica
    - name: DyanmicServiceEndpointIBMCloud
    - name: DynamicResourceAllocation
    - name: EtcdBackendQuota
    - name: EventedPLEG
    - name: Example
    - name: Example2
    - name: ExternalSnapshotMetadata
    - name: GCPClusterHostedDNS
    - name: GCPCustomAPIEndpoints
    - name: GCPCustomAPIEndpointsInstall
    - name: GCPDualStackInstall
    - name: ImageModeStatusReporting
    - name: ImageStreamImportMode
    - name: IngressControllerDynamicConfigurationManager
    - name: InsightsConfig
    - name: InsightsOnDemandDataGather
    - name: IrreconcilableMachineConfig
    - name: KMSEncryptionProvider
    - name: MachineAPIMigration
    - name: MachineAPIOperatorDisableMachineHealthCheckController
    - name: ManagedBootImagesAzure
    - name: ManagedBootImagesvSphere
    - name: MaxUnavailableStatefulSet
    - name: MinimumKubeletVersion
    - name: MixedCPUsAllocation
    - name: MultiArchInstallAzure
    - name: MultiDiskSetup
    - name: MutatingAdmissionPolicy
    - name: NewOLMCatalogdAPIV1Metas
    - name: NewOLMOwnSingleNamespace
    - name: NewOLMPreflightPermissionChecks
    - name: NewOLMWebhookProviderOpenshiftServiceCA
    - name: NoRegistryClusterOperations
    - name: NutanixMultiSubnets
    - name: OVNObservability
    - name: PreconfiguredUDNAddresses
    - name: SELinuxMount
    - name: ShortCertRotation
    - name: SignatureStores
    - name: SigstoreImageVerificationPKI
    - name: TranslateStreamCloseWebsocketRequests
    - name: VSphereConfigurableMaxAllowedBlockVolumesPerNode
    - name: VSphereHostVMGroupZonal
    - name: VSphereMixedNodeEnv
    - name: VolumeGroupSnapshot
    enabled:
    - name: AdditionalRoutingCapabilities
    - name: AdminNetworkPolicy
    - name: AlibabaPlatform
    - name: AzureWorkloadIdentity
    - name: BuildCSIVolumes
    - name: CPMSMachineNamePrefix
    - name: ConsolePluginContentSecurityPolicy
    - name: ExternalOIDC
    - name: ExternalOIDCWithUIDAndExtraClaimMappings
    - name: GCPClusterHostedDNSInstall
    - name: GatewayAPI
    - name: GatewayAPIController
    - name: HighlyAvailableArbiter
    - name: ImageVolume
    - name: KMSv1
    - name: MachineConfigNodes
    - name: ManagedBootImages
    - name: ManagedBootImagesAWS
    - name: MetricsCollectionProfiles
    - name: NetworkDiagnosticsConfig
    - name: NetworkLiveMigration
    - name: NetworkSegmentation
    - name: NewOLM
    - name: OpenShiftPodSecurityAdmission
    - name: PinnedImages
    - name: ProcMountType
    - name: RouteAdvertisements
    - name: RouteExternalCertificate
    - name: ServiceAccountTokenNodeBinding
    - name: SigstoreImageVerification
    - name: StoragePerformantSecurityPolicy
    - name: UpgradeStatus
    - name: UserNamespacesPodSecurityStandards
    - name: UserNamespacesSupport
    - name: VSphereMultiDisk
    - name: VSphereMultiNetworks
    - name: VolumeAttributesClass
    version: 4.21.0-0-2025-10-03-124858-test-ci-ln-qzdiwb2-latest
mjoseph@mjoseph-mac Downloads % 

/verified by @melvinjoseph86
/label qe-approved

[openshift-ci-robot]

@melvinjoseph86: This PR has been marked as verified by @melvinjoseph86.

In response to this:

Launch cluster-bot with this PR and the functionality is still working well and EIP are set as expected.
'SetEIPForNLBIngressController' is now removed from the featuregates.config.openshift.io

mjoseph@mjoseph-mac Downloads % oc get  featuregate cluster -oyaml
apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
 annotations:
   include.release.openshift.io/self-managed-high-availability: "true"
 creationTimestamp: "2025-10-03T13:08:26Z"
 generation: 1
 name: cluster
 resourceVersion: "712"
 uid: 9ac03c5b-1ea9-426e-8b21-eb0809df63ee
spec: {}
status:
 featureGates:
 - disabled:
   - name: AWSClusterHostedDNS
   - name: AWSClusterHostedDNSInstall
   - name: AWSDedicatedHosts
   - name: AWSDualStackInstall
   - name: AWSServiceLBNetworkSecurityGroup
   - name: AutomatedEtcdBackup
   - name: AzureClusterHostedDNSInstall
   - name: AzureDedicatedHosts
   - name: AzureDualStackInstall
   - name: AzureMultiDisk
   - name: BootImageSkewEnforcement
   - name: BootcNodeManagement
   - name: CBORServingAndStorage
   - name: ClientsAllowCBOR
   - name: ClientsPreferCBOR
   - name: ClusterAPIInstall
   - name: ClusterAPIInstallIBMCloud
   - name: ClusterAPIMachineManagementVSphere
   - name: ClusterMonitoringConfig
   - name: ClusterVersionOperatorConfiguration
   - name: DNSNameResolver
   - name: DualReplica
   - name: DyanmicServiceEndpointIBMCloud
   - name: DynamicResourceAllocation
   - name: EtcdBackendQuota
   - name: EventedPLEG
   - name: Example
   - name: Example2
   - name: ExternalSnapshotMetadata
   - name: GCPClusterHostedDNS
   - name: GCPCustomAPIEndpoints
   - name: GCPCustomAPIEndpointsInstall
   - name: GCPDualStackInstall
   - name: ImageModeStatusReporting
   - name: ImageStreamImportMode
   - name: IngressControllerDynamicConfigurationManager
   - name: InsightsConfig
   - name: InsightsOnDemandDataGather
   - name: IrreconcilableMachineConfig
   - name: KMSEncryptionProvider
   - name: MachineAPIMigration
   - name: MachineAPIOperatorDisableMachineHealthCheckController
   - name: ManagedBootImagesAzure
   - name: ManagedBootImagesvSphere
   - name: MaxUnavailableStatefulSet
   - name: MinimumKubeletVersion
   - name: MixedCPUsAllocation
   - name: MultiArchInstallAzure
   - name: MultiDiskSetup
   - name: MutatingAdmissionPolicy
   - name: NewOLMCatalogdAPIV1Metas
   - name: NewOLMOwnSingleNamespace
   - name: NewOLMPreflightPermissionChecks
   - name: NewOLMWebhookProviderOpenshiftServiceCA
   - name: NoRegistryClusterOperations
   - name: NutanixMultiSubnets
   - name: OVNObservability
   - name: PreconfiguredUDNAddresses
   - name: SELinuxMount
   - name: ShortCertRotation
   - name: SignatureStores
   - name: SigstoreImageVerificationPKI
   - name: TranslateStreamCloseWebsocketRequests
   - name: VSphereConfigurableMaxAllowedBlockVolumesPerNode
   - name: VSphereHostVMGroupZonal
   - name: VSphereMixedNodeEnv
   - name: VolumeGroupSnapshot
   enabled:
   - name: AdditionalRoutingCapabilities
   - name: AdminNetworkPolicy
   - name: AlibabaPlatform
   - name: AzureWorkloadIdentity
   - name: BuildCSIVolumes
   - name: CPMSMachineNamePrefix
   - name: ConsolePluginContentSecurityPolicy
   - name: ExternalOIDC
   - name: ExternalOIDCWithUIDAndExtraClaimMappings
   - name: GCPClusterHostedDNSInstall
   - name: GatewayAPI
   - name: GatewayAPIController
   - name: HighlyAvailableArbiter
   - name: ImageVolume
   - name: KMSv1
   - name: MachineConfigNodes
   - name: ManagedBootImages
   - name: ManagedBootImagesAWS
   - name: MetricsCollectionProfiles
   - name: NetworkDiagnosticsConfig
   - name: NetworkLiveMigration
   - name: NetworkSegmentation
   - name: NewOLM
   - name: OpenShiftPodSecurityAdmission
   - name: PinnedImages
   - name: ProcMountType
   - name: RouteAdvertisements
   - name: RouteExternalCertificate
   - name: ServiceAccountTokenNodeBinding
   - name: SigstoreImageVerification
   - name: StoragePerformantSecurityPolicy
   - name: UpgradeStatus
   - name: UserNamespacesPodSecurityStandards
   - name: UserNamespacesSupport
   - name: VSphereMultiDisk
   - name: VSphereMultiNetworks
   - name: VolumeAttributesClass
   version: 4.21.0-0-2025-10-03-124858-test-ci-ln-qzdiwb2-latest
mjoseph@mjoseph-mac Downloads % 

/verified by @melvinjoseph86
/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rikatz: This pull request references Jira Issue OCPBUGS-55649, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

This change removes the Feature gate SetEIPForNLBIngressController from the API.

The FG is not used anymore by cluster-ingress-operator and is not required to be part of the code anymore. The removal of CIO code happened on openshift/cluster-ingress-operator#1280

Additionally, the FG has been enabled by default since 4.18 and can be safely removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rikatz]

/retest-required

[rikatz]

/retest-required
Job is fixed

[rikatz]

@JoelSpeed @everettraven if the test passes now, do you mind if I remove the hold?

Thanks!

[JoelSpeed]

/hold cancel
/retest-required

[rikatz]

Test team said they are still missing a fix for it :/

[rikatz]

/retest-required
Test was timing out, team has rebalanced the clusters

[openshift-ci]

@rikatz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	1e4b0e6	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 230d0e0 and 2 for PR HEAD 1e4b0e6 in total

[rikatz]

/hold

[rikatz]

/hold cancel

[openshift-ci-robot]

@rikatz: Jira Issue Verification Checks: Jira Issue OCPBUGS-55649
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-55649 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This change removes the Feature gate SetEIPForNLBIngressController from the API.

The FG is not used anymore by cluster-ingress-operator and is not required to be part of the code anymore. The removal of CIO code happened on openshift/cluster-ingress-operator#1280

Additionally, the FG has been enabled by default since 4.18 and can be safely removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.