Skip to content

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Sep 29, 2025

Promote SigstoreImageVerificationPKI feature to make the PKI field usable by default

PKI *PKI `json:"pki,omitempty"`

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

Hello @QiWang19! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 29, 2025
@QiWang19
Copy link
Member Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@QiWang19 QiWang19 changed the title Promote SigstoreImageVerificationPKI feature to default OCPNODE-3759: Promote SigstoreImageVerificationPKI feature to default Sep 29, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2025

@QiWang19: This pull request references OCPNODE-3759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

QiWang19 commented Nov 4, 2025

/test verify-feature-promotion

@QiWang19 QiWang19 marked this pull request as ready for review November 4, 2025 20:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2025
@QiWang19
Copy link
Member Author

QiWang19 commented Nov 4, 2025

This feature does not work with our ipv6/dual stack based CI environments, so the IPv6 tests are intended to be skipped.

/test verify-feature-promotion link is expected to show following error:

error: only 0 tests found, need at least 5 for "SigstoreImageVerificationPKI" on {metal amd64 ha dual}

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2025

@QiWang19: This pull request references OCPNODE-3759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Promote SigstoreImageVerificationPKI feature to make the PKI field usable by default

PKI *PKI `json:"pki,omitempty"`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

QiWang19 commented Nov 4, 2025

/verified by @QiWang19

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 4, 2025
@openshift-ci-robot
Copy link

@QiWang19: This PR has been marked as verified by @QiWang19.

In response to this:

/verified by @QiWang19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

QiWang19 commented Nov 4, 2025

@JoelSpeed @everettraven PTAL. SigstoreImageVerificationPKI feature is ready to move to default.

This feature does not work with our ipv6/dual stack based CI environments, so the IPv6 tests are intended to be skipped.

/test verify-feature-promotion link is expected to show following error:

error: only 0 tests found, need at least 5 for "SigstoreImageVerificationPKI" on {metal amd64 ha dual}

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-feature-promotion 2b2bcc6 link true /test verify-feature-promotion
ci/prow/okd-scos-e2e-aws-ovn 2b2bcc6 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants