Add: Support for specifying elliptic curves in TLS handshake

[richardsonnick]

To support new option set default ssl curves.
Adds an option to TLSProfile config to add a list of supported groups.

See for more context openshift/cluster-ingress-operator#1287

[openshift-ci]

Hello @richardsonnick! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[everettraven]

/assign

[everettraven]

Have a handful of comments.

Additionally, this is a change to a v1 API and requires that the new field is introduced behind a new feature gate.

That means there will need to be an enhancement proposal written that includes how components are expected to behave with this change, changes that need to be made, and a plan for how the changes will be tested.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from everettraven. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[richardsonnick]

Additionally, this is a change to a v1 API and requires that the new field is introduced behind a new feature gate.

Sorry for the over sight on this, first time contributing. I'll circle back with a more in depths review of this change.

[openshift-ci]

@richardsonnick: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	93fe07b	link	true	/test verify
ci/prow/lint	93fe07b	link	true	/test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tmshort]

My main concern here is the names used for these curves, as they are pretty much all over the place.

X25519 is pretty standard, but I've also seen ecdh_x25519: (openshift/cluster-ingress-operator#1287)

Then there's the P curves. Within golang, they are referred to as:

• CurveP256
• CurveP384
• CurveP521

https://wiki.mozilla.org/Security/Server_Side_TLS refers to them as:

• prime256v1
• secp384r1

(No mention of secp521r1)
Note: OpenSSL/LibreSSL/BoringSSL also use these terms
Note: secp256r1 (usedin PR1287) is equivalent to prime256v1 but prime256v1 is more commonly used

This code seems to be using:

• P-256

(And possibly P-384 and P-521)

We should pick one and use it all over openshift, so we don't need conversion functions all over the place.