Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-18105: Update registry.svc.ci.openshift.org to registry.ci.openshift.org (bugzilla #6552) #6553

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

ArthurVardevanyan
Copy link
Contributor

Issue: #6552

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • [] None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • [] No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. api-review Categorizes an issue or PR as actively needing an API review. labels Jul 10, 2024
@openshift-ci openshift-ci bot requested review from eliorerz and eranco74 July 10, 2024 02:43
Copy link

openshift-ci bot commented Jul 10, 2024

Hi @ArthurVardevanyan. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ArthurVardevanyan ArthurVardevanyan changed the title ('#6552'): Update registry.svc.ci.openshift.org to registry.ci.opensh… ('#6552'): Update registry.svc.ci.openshift.org to registry.svc.ci.openshift.org Jul 10, 2024
@ArthurVardevanyan ArthurVardevanyan changed the title ('#6552'): Update registry.svc.ci.openshift.org to registry.svc.ci.openshift.org ('#6552'): Update registry.svc.ci.openshift.org to registry.ci.openshift.org Jul 10, 2024
@rccrdpccl
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.68%. Comparing base (d2bba26) to head (b1d8a07).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6553      +/-   ##
==========================================
+ Coverage   68.42%   68.68%   +0.26%     
==========================================
  Files         247      247              
  Lines       36425    37644    +1219     
==========================================
+ Hits        24924    25857     +933     
- Misses       9293     9527     +234     
- Partials     2208     2260      +52     
Files Coverage Δ
...oller/controllers/agentserviceconfig_controller.go 84.50% <100.00%> (-0.17%) ⬇️

... and 12 files with indirect coverage changes

@rccrdpccl
Copy link
Contributor

/retitle NO-ISSUE: (bugzilla #6552) Update registry.svc.ci.openshift.org to registry.ci.openshift.org

@openshift-ci openshift-ci bot changed the title ('#6552'): Update registry.svc.ci.openshift.org to registry.ci.openshift.org NO-ISSUE: (bugzilla #6552) Update registry.svc.ci.openshift.org to registry.ci.openshift.org Jul 12, 2024
@rccrdpccl
Copy link
Contributor

/retest

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 12, 2024
@openshift-ci-robot
Copy link

@ArthurVardevanyan: This pull request explicitly references no jira issue.

In response to this:

Issue: #6552

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • [] None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • [] No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ArthurVardevanyan ArthurVardevanyan force-pushed the ci-reg branch 2 times, most recently from 1b666e6 to a5377d3 Compare July 12, 2024 17:38
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2024
@rccrdpccl
Copy link
Contributor

/lgtm
/approve

Thanks for your contribution @ArthurVardevanyan

@gamli75 I think this should be backported to all branches, would you agree?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
Copy link

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArthurVardevanyan, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@gamli75
Copy link
Contributor

gamli75 commented Jul 15, 2024

Member

There is an open epic to change this repository https://issues.redhat.com/browse/MGMT-18105
@danmanor

@rccrdpccl
Copy link
Contributor

rccrdpccl commented Jul 15, 2024

/retitle MGMT-18105: Update registry.svc.ci.openshift.org to registry.ci.openshift.org (bugzilla #6552)

@openshift-ci openshift-ci bot changed the title NO-ISSUE: (bugzilla #6552) Update registry.svc.ci.openshift.org to registry.ci.openshift.org MGMT-18105: Update registry.svc.ci.openshift.org to registry.ci.openshift.org (bugzilla #6552) Jul 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2024

@ArthurVardevanyan: This pull request references MGMT-18105 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to this:

Issue: #6552

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • [] None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • [] No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jul 15, 2024

@ArthurVardevanyan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danmanor
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 897fb27 into openshift:master Jul 15, 2024
17 checks passed
@danmanor
Copy link
Contributor

@gamli75 Yes, we need to add quay-proxy.ci.openshift.org to the list as well

@ArthurVardevanyan ArthurVardevanyan deleted the ci-reg branch July 15, 2024 11:16
eifrach pushed a commit to eifrach/assisted-service that referenced this pull request Aug 4, 2024
danmanor added a commit to danmanor/assisted-service that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants