Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OKD podman deploy #6562 #6585

Closed
wants to merge 2 commits into from

Conversation

mlorenzofr
Copy link
Contributor

@mlorenzofr mlorenzofr commented Jul 17, 2024

This PR fixes the deploy of OKD using podman. More info in the issue #6562

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2024
@openshift-ci openshift-ci bot requested review from ori-amizur and romfreiman July 17, 2024 14:35
@rccrdpccl
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.57%. Comparing base (6440103) to head (9966c2b).
Report is 2 commits behind head on master.

Current head 9966c2b differs from pull request most recent head fcc4f78

Please upload reports for the commit fcc4f78 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6585   +/-   ##
=======================================
  Coverage   68.57%   68.57%           
=======================================
  Files         247      246    -1     
  Lines       36705    36687   -18     
=======================================
- Hits        25169    25158   -11     
+ Misses       9294     9291    -3     
+ Partials     2242     2238    -4     

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2024
@rccrdpccl
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
Copy link

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlorenzofr, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jul 18, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024
Copy link

openshift-ci bot commented Jul 18, 2024

@mlorenzofr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-e2e-metal-assisted 9966c2b link true /test edge-e2e-metal-assisted
ci/prow/edge-e2e-metal-assisted-static-ip-suite-4-14 9966c2b link false /test edge-e2e-metal-assisted-static-ip-suite-4-14
ci/prow/edge-e2e-metal-assisted-day2-single-node 9966c2b link false /test edge-e2e-metal-assisted-day2-single-node
ci/prow/edge-e2e-metal-assisted-day2 9966c2b link false /test edge-e2e-metal-assisted-day2
ci/prow/edge-e2e-metal-assisted-ipv4v6 9966c2b link false /test edge-e2e-metal-assisted-ipv4v6
ci/prow/edge-e2e-metal-assisted-bond 9966c2b link false /test edge-e2e-metal-assisted-bond
ci/prow/edge-e2e-metal-assisted-static-ip-suite 9966c2b link false /test edge-e2e-metal-assisted-static-ip-suite
ci/prow/edge-e2e-metal-assisted-single-node 9966c2b link false /test edge-e2e-metal-assisted-single-node
ci/prow/edge-e2e-metal-assisted-bond-4-14 9966c2b link false /test edge-e2e-metal-assisted-bond-4-14

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mlorenzofr mlorenzofr closed this Jul 18, 2024
@mlorenzofr mlorenzofr deleted the okd-podman-readme branch July 18, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants