-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-18627: Align assisted authorization service with OCM authorizations #6982
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
@dudyas6: This pull request references MGMT-18627 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dudyas6 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
28eb660
to
276476b
Compare
@@ -156,6 +157,8 @@ def main(): | |||
y['data']['DISK_ENCRYPTION_SUPPORT'] = deploy_options.disk_encryption_support | |||
|
|||
y['data']['ENABLE_ORG_TENANCY'] = deploy_options.enable_org_tenancy | |||
|
|||
y['data']['ENABLE_OCM_AUTHZ'] = deploy_options.enable_ocm_authz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add ENABLE_OCM_AUTHZ
in the configmap manifest
b5e60d1
to
f33d865
Compare
f33d865
to
babf3ac
Compare
@dudyas6: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist