MGMT-18288: Approve CSRs for agents with baremetal platform without MAPI #7076
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@CrystalChun: This pull request references MGMT-18288 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
/test all |
openshift-ci
bot
added
the
size/M
|
@CrystalChun: This pull request references MGMT-18288 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@CrystalChun: This pull request references MGMT-18288 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@CrystalChun: This pull request references MGMT-18288 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@CrystalChun: This pull request references MGMT-18288 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7076 +/- ##
==========================================
- Coverage 67.83% 67.75% -0.09%
==========================================
Files 289 293 +4
Lines 39660 39934 +274
==========================================
+ Hits 26905 27058 +153
- Misses 10328 10436 +108
- Partials 2427 2440 +13
|
CrystalChun
force-pushed
the
approve-non-mapi-csrs
branch
2 times, most recently
from
abb77de to
f601500
Compare
|
/test all |
CrystalChun
force-pushed
the
approve-non-mapi-csrs
branch
from
f601500 to
87740e5
Compare
|
/test ? |
|
@CrystalChun: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test edge-e2e-ai-operator-ztp-node-labels |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test edge-e2e-ai-operator-ztp-node-labels |
CrystalChun
force-pushed
the
approve-non-mapi-csrs
branch
from
87740e5 to
f29e95c
Compare
openshift-ci
bot
added
size/L
CrystalChun
force-pushed
the
approve-non-mapi-csrs
branch
from
f29e95c to
60da91b
Compare
Yes! Added two for the Agent controller:
The BMAC has a test from the last PR. Let me know if you think additional tests are needed! |
|
/test edge-e2e-ai-operator-ztp-node-labels |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
| }, | ||
| expectedStatus: models.HostStatusInstalling, | ||
| expectedStage: models.HostStageJoined, | ||
| clusterInstall: newAciBaremetalWithoutMAPI("test-cluster-aci", testNamespace), |
There was a problem hiding this comment.
Why does this say "WithoutMAPI" but the test name says "with MAPI"?
There was a problem hiding this comment.
Oops, the naming is incorrect, modified it!
There are no spoke bmh and machines created for a host that's installed to a cluster with baremetal platform without MAPI capability. We need to approve their CSRs too.
CrystalChun
force-pushed
the
approve-non-mapi-csrs
branch
from
60da91b to
eb81629
Compare
|
/test edge-e2e-ai-operator-ztp-node-labels |
|
@CrystalChun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, CrystalChun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 96a1434
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-api-server |
There are no spoke bmh and machines created for a host that's installed to a cluster with baremetal platform without MAPI capability. We need to approve their CSRs too.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist