NO-ISSUE: Allow use of 'envtest'

[jhernand]

This patch prepares the project so that tests will be able to use the 'envtest' package.

List all the issues related to this PR

https://issues.redhat.com/browse/MGMT-19120

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@jhernand: This pull request explicitly references no jira issue.

In response to this:

This patch prepares the project so that tests will be able to use the 'envtest' package.

List all the issues related to this PR

https://issues.redhat.com/browse/MGMT-19120

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhernand]

/test edge-unit-test

[jhernand]

/retest-required

[codecov]

Codecov Report

Attention: Patch coverage is 34.21053% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.53%. Comparing base (80007d2) to head (37ca941).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/testing/envtest.go	34.21%	24 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7100      +/-   ##
==========================================
- Coverage   67.73%   67.53%   -0.21%     
==========================================
  Files         293      296       +3     
  Lines       39925    40079     +154     
==========================================
+ Hits        27042    27066      +24     
- Misses      10440    10572     +132     
+ Partials     2443     2441       -2     

Files with missing lines	Coverage Δ
internal/testing/envtest.go	34.21% <34.21%> (ø)

... and 5 files with indirect coverage changes

[paul-maidment]

I'm cool with this being a 'NO-ISSUE' but would love more context on what you have planned.

Looks like integration tests, somewhere between unit and subsystem?

[jhernand]

@paul-maidment I need/want this for the tests that I am adding in #7090. I'd call those are unit tests, in the same sense that tests that use a database are unit tests, only that here the underlying infrastructure is a Kubernetes API server instead of a database. But I am fine if we want to call them "integration" or anything else.

[rccrdpccl]

/lgtm

great addition ❤️

[rccrdpccl]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhernand,rccrdpccl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 88ff532 and 2 for PR HEAD 37ca941 in total

[paul-maidment]

/test okd-scos-e2e-aws-ovn

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 88ff532 and 2 for PR HEAD 37ca941 in total

[openshift-ci]

@jhernand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	37ca941	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.