MGMT-19792: Add discovery ignition URL to the infraenv status #7243
Conversation
|
@carbonin: This pull request references MGMT-19792 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
size/M
openshift-ci
bot
added
api-review
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7243 +/- ##
==========================================
+ Coverage 67.89% 68.02% +0.12%
==========================================
Files 298 300 +2
Lines 40711 41026 +315
==========================================
+ Hits 27642 27908 +266
- Misses 10592 10625 +33
- Partials 2477 2493 +16
|
api/v1beta1/infraenv_types.go
Outdated
| @@ -202,6 +202,9 @@ type BootArtifacts struct { | |||
| // IpxeScriptURL specifies an HTTP/S URL that contains the iPXE script | |||
| // +optional | |||
| IpxeScriptURL string `json:"ipxeScript"` | |||
| // DiscoveryIgnitionURL specifies and HTTP/S URL that contains the discovery ignition | |||
There was a problem hiding this comment.
Sorry just noticed this tiny bit
| // DiscoveryIgnitionURL specifies and HTTP/S URL that contains the discovery ignition | |
| // DiscoveryIgnitionURL specifies an HTTP/S URL that contains the discovery ignition |
Looks good otherwise!
carbonin
force-pushed
the
discovery-ignition-api
branch
from
f1d643c to
17f9aca
Compare
This will mainly be used with integrations that provide the discovery ignition as metadata to hosts that boot with a generic disk image rather than the discovery ISO, but can also be used for debugging. Resolves https://issues.redhat.com/browse/MGMT-19792
carbonin
force-pushed
the
discovery-ignition-api
branch
from
17f9aca to
6343136
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, CrystalChun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@carbonin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 4dbd6fe
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-api-server |
This will mainly be used with integrations that provide the discovery ignition as metadata to hosts that boot with a generic disk image rather than the discovery ISO, but can also be used for debugging.
Resolves https://issues.redhat.com/browse/MGMT-19792
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Deployed assisted service with this change, created an infraenv, downloaded and checked the discovery ignition using the URL in new API
Checklist
docs, README, etc)Reviewers Checklist