Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1575: Rebase to v1.26.1 for OCP 4.16 #257

Merged
merged 45 commits into from
Feb 12, 2024

Conversation

RomanBednar
Copy link

AndrewSirenko and others added 30 commits November 10, 2023 15:53
Signed-off-by: Connor Catlett <[email protected]>
meta-data/block-device-mapping reports devices that were attached to the
VM at the time the VM was started. It does not reflect devices
attached/detached later.

In addition, even when it showed the attachments accurately, the CSI driver
uses this information only at the driver startup. At this time, there
may be some CSI volumes attached from the previous node boot. Those
volumes are then counted as permanently attached to the node, while
Kubernetes may detach them later.

Therefore do not count block-device-mapping at all and always reserve just
1 attachment for the root disk. Assume all other attachments are CSI
volumes, and let Kubernetes do the calculations of attached volumes
instead.
…vice-mapping

Remove block-device-mapping from attach limit
Refactor E2E: Remove hidden performance parameter setting

Fixup E2E: Pre-Provisioned volumes don't use VolumeType

Fixup E2E: Pre-Provisioned defaultVolumeType typo

Refactor E2E: Standardize adding CreateVolume parameters to testcases

Refactor E2E: Generalize format_options CreateVolumeDetails helper fcn.
Refactor E2E: Streamline setting of CreateVolume Parameters in test-cases.
Add release scripts for upgrading sidecar dependencies and collating image digests
…eReleasePr

Add generate-release-pr to /hack/release-scripts
…olumePostRefactor

Add E2E tests for modifying volumes via annotations
…ackport

Upgrade golangci-lint to version that supports go1.21.5
…verwriting existing with nil

Signed-off-by: Connor Catlett <[email protected]>
Add volume/snapshot tagging and FSR e2e tests
Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
to fix CVE-2023-47108.

See GHSA-8pgv-569h-w5rw
for details.
Replace it with otelgrpc.NewServerHandler.
k8s-ci-robot and others added 12 commits December 14, 2023 03:25
Add warning about --reuse-values to NOTES.txt
…sigs#1867)

Upgrade Prow CI job dependencies for aws-ebs-csi-driver v1.26.0

Upgrade sidecar images for aws-ebs-csi-driver v1.26.0

Update mocks for aws-ebs-csi-driver v1.26.0

Fix govet error due to dependency upgrades in e2e tests.

Add U7i attachment limits
…gression-fix

Remove regression for GP3 storage classes below 3000 IOPS
- Remove .github files: we don't want custom templates or dependabots in
  OpenShift forks.

- Compile with -mod=vendor

- Compile without KUBECONFIG: hack/verify-kustomize reads the current
  namespace and adds it into generated / verified manifests.
With KUBECONFIG="", it won't be able to get the namespace and thus it will
generate manifests with namespace: default.

- Add .snyk file to ignore false positives
Upstream does not store it in git.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2024

@RomanBednar: This pull request references STOR-1575 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Diff to upstream v1.26.1:
kubernetes-sigs/aws-ebs-csi-driver@v1.26.1...RomanBednar:rebase-v1.26.1

Notable changes since v1.25.0 (OCP 4.15):

Full changelog: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
Copy link

openshift-ci bot commented Jan 17, 2024

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@Phaow
Copy link

Phaow commented Jan 31, 2024

/label qe-approved
CI looks good. The notabel changes of U7i attachment limits, u7i instances still in preview currently we haven't join the preview will test later after the instances become avaiable.

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 31, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2024

@RomanBednar: This pull request references STOR-1575 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Diff to upstream v1.26.1:
kubernetes-sigs/aws-ebs-csi-driver@v1.26.1...RomanBednar:rebase-v1.26.1

Notable changes since v1.25.0 (OCP 4.15):

Full changelog: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dobsonj
Copy link
Member

dobsonj commented Feb 12, 2024

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Feb 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b79b00b into openshift:master Feb 12, 2024
10 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-ebs-csi-driver-container-v4.16.0-202402130109.p0.gb79b00b.assembly.stream.el9 for distgit ose-aws-ebs-csi-driver.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants