Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: STOR-2253: Rebase to upstream v1.39.0 for OCP 4.19 #283

Open
wants to merge 237 commits into
base: master
Choose a base branch
from

Conversation

rhrmo
Copy link

@rhrmo rhrmo commented Feb 5, 2025

Issue link:
https://issues.redhat.com/browse/STOR-2253

Diff to upstream v1.39.0:
kubernetes-sigs/aws-ebs-csi-driver@v1.39.0...rhrmo:rebase-v1.39.0

Important changes between v1.34.0 (OCP 4.18) and v1.39.0 (OCP 4.19):
TODO

Full changelogs:
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

/hold

AndrewSirenko and others added 30 commits August 20, 2024 16:59
Update faq.md with Karpenter best practices
* Add local snapshots on outposts

* Fix OutPostArnKey in switch statement

* Add arn verification and VSC paramater doc

* Fix assignment of outpostArn outisde if statement

* Fix typo in snapshot.md

* Removed information found in linked docs
…erved

Add reservedVolumeAttachments to windows nodes
Add node.legacyXFS parameter to fix XFS on nodes with kernel version ≤ 5.4
…-2.0

Auto-enable VAC on clusters with beta API version
…k-optional

Make govulncheck only run on release branches
…le-support

Add support for outpost nodegroups to `make cluster/create`
The existing test does not correctly test the "only existing" behavior
(and only functions because of a typo in the test), fix that by moving
it to before the fallback test (where it needs to be) and correctly
setting up the existing names map

Also, added some comments to make what is being tested more clear

Signed-off-by: Connor Catlett <[email protected]>
AndrewSirenko and others added 21 commits December 27, 2024 16:44
Update volume modification example 6 hour cooldown note
Change make test to also run sanity tests
Signed-off-by: Connor Catlett <[email protected]>
Bump dependencies and lock errdefs version to v0.1.0
Refactor driver permissions docs and add Pod Identities
…wait-for-volume

Fix wait for volume ready ~60s
…#2304)

* Bump dependencies for 1.39 release

* fixup! Bump dependencies for 1.39 release

---------

Co-authored-by: elijah quinones <[email protected]>
…mpat

Fix typo in Makefile a1compat target
- Remove .github files: we don't want custom templates or dependabots in
  OpenShift forks.

- Compile with -mod=vendor

- Compile without KUBECONFIG: hack/verify-kustomize reads the current
  namespace and adds it into generated / verified manifests.
With KUBECONFIG="", it won't be able to get the namespace and thus it will
generate manifests with namespace: default.

- Compile tools (not the main driver binary!) with -mod=readonly,
  so `make verify` can compile mockgen from the internet.

- Add .snyk file to ignore false positives

- Add vendor/ dir
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025

@rhrmo: This pull request references STOR-2253 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Issue link:
https://issues.redhat.com/browse/STOR-2253

Diff to upstream v1.39.0:
kubernetes-sigs/aws-ebs-csi-driver@v1.39.0...rhrmo:rebase-v1.39.0

Important changes between v1.34.0 (OCP 4.18) and v1.39.0 (OCP 4.19):
TODO

Full changelogs:
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025
@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana February 5, 2025 15:17
Copy link

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhrmo
Once this PR has been reviewed and has the lgtm label, please assign romanbednar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Feb 5, 2025

@rhrmo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 25ca3de link true /test verify
ci/prow/verify-deps 25ca3de link true /test verify-deps
ci/prow/unit 25ca3de link true /test unit
ci/prow/images 25ca3de link true /test images
ci/prow/okd-scos-e2e-aws-ovn 25ca3de link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-csi-extended 25ca3de link false /test e2e-aws-csi-extended
ci/prow/e2e-aws-ovn-upgrade 25ca3de link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-csi 25ca3de link true /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhrmo rhrmo changed the title STOR-2253: Rebase to upstream v1.39.0 for OCP 4.19 WIP: STOR-2253: Rebase to upstream v1.39.0 for OCP 4.19 Feb 6, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.