Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM-436: Cleanup kube-rbac-proxy #100

Open
wants to merge 1 commit into
base: release-1.15
Choose a base branch
from

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Dec 9, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2024

@swghosh: This pull request references CM-436 which is a valid jira issue.

In response to this:

Follow-up over openshift/cert-manager-operator#221

FYI, this is not a required change for cert-manager-1.15 release, we can target this for 1.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swghosh
Once this PR has been reviewed and has the lgtm label, please assign trilokgeer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2024

@swghosh: This pull request references CM-436 which is a valid jira issue.

In response to this:

Follow-up over openshift/cert-manager-operator#221

also, xref: #95

FYI, this is not a required change for cert-manager-1.15 release, we can target this for 1.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2024

@swghosh: This pull request references CM-436 which is a valid jira issue.

In response to this:

Follow-up over openshift/cert-manager-operator#221, ref: #95

FYI, this is not a required change for cert-manager-1.15 release, we can target this for 1.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@swghosh
Copy link
Member Author

swghosh commented Dec 16, 2024

/cc TrilokGeer

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2024

@swghosh: This pull request references CM-436 which is a valid jira issue.

In response to this:

Follow-up over openshift/cert-manager-operator#221, ref: #95

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.


CATALOG_MANIFEST_FILE_NAME="catalog.yaml"


# TODO: [future] de-dup this function, as this is the same logic from render_templates.sh->update_csv_manifest()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this script, its not used anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants