when no type is specified, don't make illegal condition

openshift · Sep 27, 2024 · 1004eef · 1004eef
1 parent e56f20d
commit 1004eef
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/controllers/routercerts/controller.go b/pkg/controllers/routercerts/controller.go
@@ -100,6 +100,11 @@ func (c *routerCertsDomainValidationController) sync(ctx context.Context, syncCt
 	// set the condition anywhere in sync() to update the controller's degraded condition
 	var condition operatorv1.OperatorCondition
 	defer func() {
+		if len(condition.Type) == 0 {
+			// no change is desired.  This happens when the SyncPartialSecret fails
+			return
+		}
+
 		_, _, err = v1helpers.UpdateStatus(ctx, c.operatorClient, v1helpers.UpdateConditionFn(condition))
 	}()