[WIP] wait for etcd cluster bootstrap to complete and then tear down etcd static pod #114
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| manifests := make([]string, 0) | ||
| manifests = append(manifests, b.ownedManifests...) | ||
| // etcd static pod is not included in b.ownedManifests | ||
| manifests = append(manifests, filepath.Join(b.podManifestPath, "etcd-member-pod.yaml")) |
There was a problem hiding this comment.
there is still a race condition a) when the etcd bootstrap member is removed from the cluster, and the etcd process terminates as a consequence b) cluster-bootstrap removing the static manifest for etcd pod
Maybe we don't need a anymore? cluster-bootstrap waits for the EtcdRunningInCluster condition to be true, and then it deletes the static pod from during teardown?
tkashem
changed the title
|
@tkashem: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.