Skip to content

OCPCLOUD-3081: Update to Kube 1.34 deps #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2025
Merged

OCPCLOUD-3081: Update to Kube 1.34 deps #428

merged 3 commits into from
Nov 11, 2025

Conversation

@nrb
Copy link
Contributor

@nrb nrb commented Nov 3, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 3, 2025 •
edited by openshift-ci bot
Loading

@nrb: This pull request references OCPCLOUD-3081 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025
nrb added 2 commits November 3, 2025 16:37
@nrb
Update to Kube 1.34 deps
a73374e 
Signed-off-by: Nolan Brubaker <[email protected]>
@nrb
Vendor Kube 1.34 deps
606aea0 
Signed-off-by: Nolan Brubaker <[email protected]>
@nrb
Copy link
Contributor Author

nrb commented Nov 3, 2025

/test unit,vet,verify-deps,images,vendor

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

@nrb: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-ovn

/test e2e-aws-ovn-upgrade

/test fmt

/test images

/test lint

/test okd-scos-images

/test unit

/test vendor

/test verify-deps

/test vet

The following commands are available to trigger optional jobs:

/test e2e-aws-ovn-techpreview

/test e2e-azure-manual-oidc

/test e2e-azure-ovn

/test e2e-azure-ovn-upgrade

/test e2e-gcp-ovn

/test e2e-gcp-ovn-upgrade

/test e2e-ibmcloud-ovn

/test e2e-nutanix-ovn

/test e2e-openstack-ovn

/test e2e-vsphere-ovn

/test level0-clusterinfra-azure-ipi-proxy-tests

/test okd-scos-e2e-aws-ovn

/test regression-clusterinfra-vsphere-ipi-ccm

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-upgrade

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-fmt

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-images

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-level0-clusterinfra-azure-ipi-proxy-tests

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-lint

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-okd-scos-e2e-aws-ovn

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-okd-scos-images

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-regression-clusterinfra-vsphere-ipi-ccm

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-unit

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-vendor

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-verify-deps

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-vet

In response to this:

/test unit,vet,verify-deps,images,vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nrb
Copy link
Contributor Author

nrb commented Nov 3, 2025

/test unit
/test vet
/test verify-deps
/test images
/test vendor

@nrb
Copy link
Contributor Author

nrb commented Nov 6, 2025

/test unit
/test lint
/test images
/test fmt

@mtulio
Copy link
Contributor

mtulio commented Nov 6, 2025

/test vendor vet verify-deps

@mtulio
Copy link
Contributor

mtulio commented Nov 6, 2025

/test e2e-aws-ovn

@mtulio
Copy link
Contributor

mtulio commented Nov 6, 2025 •
edited
Loading

I believe this is also important to validate the fix in the unit hashes:

/test e2e-aws-ovn-upgrade

@mtulio
Copy link
Contributor

mtulio commented Nov 6, 2025

/test e2e-azure-ovn-upgrade

@mtulio
Copy link
Contributor

mtulio commented Nov 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@mtulio mtulio mentioned this pull request Nov 7, 2025
Open
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@nrb
Copy link
Contributor Author

nrb commented Nov 7, 2025

/test unit
/test lint
/test verify-deps
/test vet

@nrb @claude
Update spec hashes to be calculated during tests
21f19fa 
Kube 1.34 updated the creationTimestamp field to be omitzero, which
means that a null value will not be output at all. Before, the field
would be serialized as `creationTimestamp = null`.

This change meant that the serialization that we generate our hashes
from changed.

In practice this field should never be unset, but we're updating the
tests to remove hard-coded values anyway.

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Nolan Brubaker <[email protected]>
@nrb nrb marked this pull request as ready for review November 9, 2025 19:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2025
@openshift-ci openshift-ci bot requested review from mdbooth and racheljpg November 9, 2025 19:02
@mtulio
Copy link
Contributor

mtulio commented Nov 9, 2025

/test e2e-azure-ovn-upgrade e2e-aws-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2025

@nrb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor

mtulio commented Nov 9, 2025

Thanks!

per tests passing and unit fixed:

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2025
@sunzhaohua2
Copy link
Contributor

sunzhaohua2 commented Nov 10, 2025

/verified by @sunzhaohua2
regression job passed

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 10, 2025

@sunzhaohua2: This PR has been marked as verified by @sunzhaohua2.

In response to this:

/verified by @sunzhaohua2
regression job passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo
damdo reviewed Nov 11, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks @nrb

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8259332 into openshift:main Nov 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@mdbooth mdbooth Awaiting requested review from mdbooth

@racheljpg racheljpg Awaiting requested review from racheljpg

Assignees

@mtulio mtulio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nrb @openshift-ci-robot @mtulio @sunzhaohua2 @damdo