CNTRLPLANE-1769: Update to v3.6.5 #1507
Open
+79,951
−33,535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
jira/valid-reference
|
@dusk125: This pull request references CNTRLPLANE-1769 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
WalkthroughUpdate many dependencies in go.mod; migrate tests to updated integration API (ClusterV3 → Cluster, NewClusterV3 → NewCluster, ClusterClient() → ClusterClient(t), GRPCURL() → GRPCURL); switch some etcd error imports to etcdserver/errors; rename several ETCD env keys; and change etcd startup flags in templates. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.5.0)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
Contributor
Author
|
/hold for openshift/etcd#343 |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (293)
go.sumis excluded by!**/*.sumvendor/github.com/VividCortex/ewma/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/VividCortex/ewma/.whitesourceis excluded by!vendor/**,!**/vendor/**vendor/github.com/VividCortex/ewma/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/VividCortex/ewma/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/VividCortex/ewma/codecov.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/VividCortex/ewma/ewma.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/LICENSE_WINDOWSis excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/Readme.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/speakeasy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/speakeasy_unix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/speakeasy_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/element.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/io.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/pb.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/pool.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/pool_win.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/pool_x.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/preset.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/speed.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/template.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_aix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_appengine.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_bsd.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_linux.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_nix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_plan9.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_solaris.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_win.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_x.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/LICENSE.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/color.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/color_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/MIGRATION_GUIDE.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/claims.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/map_claims.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/parser.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/parser_option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/token.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/MIGRATION_GUIDE.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/SECURITY.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/VERSION_HISTORY.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/claims.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/ecdsa.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/ecdsa_utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/ed25519.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/ed25519_utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/errors_go1_20.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/errors_go_other.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/hmac.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/map_claims.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/none.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/parser.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/parser_option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/registered_claims.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/rsa.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/rsa_pss.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/rsa_utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/signing_method.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/staticcheck.confis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/token.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/token_option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/descriptor/descriptor.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/jsonpb/decode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/jsonpb/encode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/jsonpb/json.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/protoc-gen-go/descriptor/descriptor.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/ptypes/any/any.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/ptypes/duration/duration.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/ptypes/timestamp/timestamp.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/ptypes/wrappers/wrappers.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/cmpopts/equate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/cmpopts/ignore.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/cmpopts/sort.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/cmpopts/struct_filter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/cmpopts/xform.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/chain.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/makefileis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/client_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/client_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/constants.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/reporter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/server_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/server_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/slack.pngis excluded by!**/*.png,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/COPYRIGHTis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/callmeta.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/reporter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/wrappers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/LICENSE.txtis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/internal/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/internal/errors.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/internal/errors.protois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/convert.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/fieldmask.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/handler.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshal_httpbodyproto.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshal_json.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshal_jsonpb.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshal_proto.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshaler.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshaler_registry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/mux.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/pattern.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/proto2_convert.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/proto_errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/query.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/utilities/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/utilities/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/utilities/pattern.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/utilities/readerfactory.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/utilities/trie.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/annotations.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/annotations.protois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/annotations_protoopaque.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/buf.gen.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2.protois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2_protoopaque.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/handler.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/mux.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/query.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/SECURITY.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/clockwork.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/ticker.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/timer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/colorable_others.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/colorable_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/go.test.shis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/noncolorable.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/go.test.shis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_bsd.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_others.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_plan9.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_solaris.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_tcgets.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth_appengine.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth_js.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth_posix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth_table.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/LICENSE.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/csv.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/table.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/table_with_color.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/wrap.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/LICENSE.txtis excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/eastasianwidth.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/emojipresentation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/gen_breaktest.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/gen_properties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/grapheme.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/graphemeproperties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/graphemerules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/line.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/lineproperties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/linerules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/properties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/sentence.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/sentenceproperties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/sentencerules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/step.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/width.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/word.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/wordproperties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/wordrules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/active_help.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/bash_completionsV2.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/cobra.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/command.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/powershell_completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/.golangci.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/flag.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/ip.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/ipnet_slice.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/string_array.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/.go-versionis excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/Makefileis excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/OWNERSis excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/README.mdis excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_386.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_aix.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_android.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_arm.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_mips64x.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_mipsx.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_solaris.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_unix.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_windows.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/boltsync_unix.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bucket.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/cursor.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/db.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/errors.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/errors/errors.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/freelist.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/freelist_hmap.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_386.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_arm.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_mips64x.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_mipsx.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bucket.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/inode.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/meta.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/page.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/types.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/unsafe.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/utils.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/verify.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/freelist/array.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/freelist/freelist.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/freelist/hashmap.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/freelist/shared.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/logger.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/mlock_unix.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/node.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/page.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/tx.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/tx_check.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/etcd/api/v3/authpb/auth.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/go.etcd.io/etcd/api/v3/authpb/auth.protois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (7)
go.mod(5 hunks)pkg/cmd/monitor/monitor_test.go(4 hunks)pkg/cmd/rev/rev_test.go(5 hunks)pkg/etcdcli/etcdcli.go(2 hunks)pkg/etcdcli/etcdcli_pool_test.go(20 hunks)pkg/operator/clustermembercontroller/clustermembercontroller.go(2 hunks)pkg/operator/defragcontroller/defragcontroller_test.go(5 hunks)
🔇 Additional comments (19)
pkg/etcdcli/etcdcli.go (2)
23-23: LGTM: Error import updated to new package structure.The import path change from
etcdservertoetcdserver/errorsaligns with etcd v3.6.5's refactored error handling structure.
205-205: LGTM: Error comparison updated consistently.The error reference is correctly updated to
errors.ErrLearnerNotReadyto match the new import. The string comparison approach remains appropriate given the error type constraints mentioned in the code comments.pkg/operator/clustermembercontroller/clustermembercontroller.go (1)
12-12: LGTM: Error handling updated consistently with etcd v3.6.5.The import path and error reference changes match the refactoring in
pkg/etcdcli/etcdcli.go, maintaining consistency across the codebase.Also applies to: 291-291
pkg/operator/defragcontroller/defragcontroller_test.go (2)
25-25: LGTM: Test framework import updated.The import path change to
framework/integrationreflects the reorganized test utilities in etcd v3.6.5.
172-172: LGTM: Test cluster construction and API updated.The migration from
NewClusterV3toNewClusterand the change frommember.GRPCURL()method call tomember.GRPCURLfield access align with the new test framework API in etcd v3.6.5. These changes are applied consistently throughout both test functions.Also applies to: 183-183
pkg/cmd/monitor/monitor_test.go (3)
16-16: LGTM: Test framework types updated.The import and type changes from
ClusterV3toClusterare consistent with the etcd v3.6.5 test framework migration.Also applies to: 34-34
83-87: LGTM: Test cluster setup migrated to new API.The function signature and implementation correctly adopt the new test framework:
- Returns
*integration.Clusterinstead of*integration.ClusterV3- Uses
NewClusterconstructor- Accesses
GRPCURLas a field
220-220: LGTM: Helper function signatures updated consistently.Both
pauseEtcdPeersandstopEtcdPeerscorrectly accept*integration.Clusterinstead of*integration.ClusterV3.Also applies to: 228-228
pkg/etcdcli/etcdcli_pool_test.go (3)
12-12: LGTM: Test framework import updated.Import path updated to
framework/integrationas part of the etcd v3.6.5 migration.
33-33: LGTM: All test cluster constructions updated consistently.All 15 test cluster instantiations have been migrated from
NewClusterV3toNewCluster, maintaining consistency across the entire test suite.Also applies to: 49-49, 66-66, 90-90, 114-114, 139-139, 173-173, 214-214, 257-257, 279-279, 306-306, 334-334, 363-363, 376-376, 391-391
424-456: LGTM: Test helper function updated to new API.The
newTestPoolfunction correctly adopts the new test framework requirements:
- Accepts
testing.TBparameter (Line 424)- Uses
GRPCURLfield access instead of method call (Lines 442)- Passes
ttoClusterClient(t)(Line 455)These changes align with etcd v3.6.5's requirement for test context in cluster client operations.
pkg/cmd/rev/rev_test.go (3)
14-14: LGTM: Test framework import updated.Import path migrated to
framework/integrationfor etcd v3.6.5 compatibility.
19-19: LGTM: ClusterClient calls updated with test context.All three test functions correctly pass the
tparameter toClusterClient(t), matching the new API requirement in etcd v3.6.5.Also applies to: 41-41, 74-74
122-152: LGTM: Test setup function fully migrated to new framework.The
setupTestClusterfunction comprehensively adopts the new test framework:
- Returns
*integration.Cluster(Line 122)- Uses
NewClusterconstructor (Line 124)- Passes
ttoClusterClient(t)in both the newFunc (Line 137) and endpointsFunc (Line 140) closuresgo.mod (5)
35-35: I'll search for information about gRPC v1.71.1's stability and any compatibility concerns with etcd.Let me search for more specific information about gRPC v1.71 in the context of Go-based etcd clients and operators.
No actionable concerns identified with gRPC v1.71.1 stability or compatibility.
gRPC v1.71.0 is a stable release containing refinements, improvements, and bug fixes, and v1.71.1 is a standard maintenance patch. etcd v3.6.0 upgraded grpc-gateway from v1 to v2, but no specific gRPC version constraints are documented for the etcd v3.6.x series. etcd v3 uses gRPC for remote procedure calls, and the Go etcd client library supports the modern gRPC ecosystem without explicit version restrictions. No known compatibility issues exist between gRPC v1.71.1 and etcd v3.6.5 for Go-based operators.
121-121: OpenTelemetry v1.34.0 is stable and compatible with this project.OpenTelemetry Go v1.34.0 was released January 17, 2025, and includes fixes for the Logs API and exporter Type names. The minimum Go version requirement is 1.22, which is satisfied by this project's Go 1.24.0 target. No widely reported security vulnerabilities are tied to v1.34.0. The updates to
otel/sdk,otel/trace,otel/metric, and related exporters (lines 123–128) are stable and production-ready.
3-5: Go 1.24.0 support is properly configured and verified.The codebase and all transitive dependencies explicitly require Go 1.24.0 (confirmed in vendor/modules.txt). The toolchain is pinned to go1.24.4, which includes the security fix from 1.24.3. The codebase uses none of the breaking APIs from Go 1.24.x (no cgo receiver aliasing, os.Root usage, or problematic generics). The build infrastructure (OpenShift CI with build-machinery-go) properly handles Go version validation. No compatibility issues detected.
86-88: No compatibility issues found — versions are verified as compatible.The indirect dependencies for grpc-middleware and grpc-gateway have been verified:
- gRPC-gateway v2.26.3 works with grpc-go v1.71.1
- etcd v3.6.5 uses google.golang.org/grpc v1.71.1
- grpc-middleware v1 and v2 can coexist in the same Go build because they use different module paths (/v2 suffix)
Additionally, no direct imports of v2 packages were found in source code—the v2 dependencies appear only as transitive/indirect dependencies in vendor, meaning no API-level breaking changes are in play. The dependency update is safe.
28-32: Etcd v3.6.5 upgrade is compatible—no code changes required.Etcd v3.6.5's breaking changes (on-disk schema incompatibility, peer/client endpoint separation, v2 store removal) do not impact the cluster-etcd-operator code. The operator already properly separates peer URLs from client URLs in member management, does not use the deprecated v2 store, and Go 1.24.0 exceeds the minimum Go 1.19+ requirement. No breaking API changes to etcd's client library affect the operator's current usage patterns.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
go.mod (1)
119-119: Duplicate: Update go.etcd.io/raft/v3 to v3.6.5.The raft module version (v3.6.0) does not match other etcd modules (v3.6.5), creating a compatibility issue. This was already flagged in a previous review.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (287)
go.sumis excluded by!**/*.sumvendor/github.com/VividCortex/ewma/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/VividCortex/ewma/.whitesourceis excluded by!vendor/**,!**/vendor/**vendor/github.com/VividCortex/ewma/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/VividCortex/ewma/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/VividCortex/ewma/codecov.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/VividCortex/ewma/ewma.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/LICENSE_WINDOWSis excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/Readme.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/speakeasy.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/speakeasy_unix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/bgentry/speakeasy/speakeasy_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/element.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/io.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/pb.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/pool.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/pool_win.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/pool_x.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/preset.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/speed.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/template.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_aix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_appengine.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_bsd.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_linux.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_nix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_plan9.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_solaris.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_win.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/termutil/term_x.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/cheggaaa/pb/v3/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/LICENSE.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/color.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/color_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/fatih/color/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/MIGRATION_GUIDE.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/claims.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/map_claims.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/parser.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/parser_option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v4/token.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/MIGRATION_GUIDE.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/SECURITY.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/VERSION_HISTORY.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/claims.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/ecdsa.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/ecdsa_utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/ed25519.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/ed25519_utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/errors_go1_20.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/errors_go_other.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/hmac.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/map_claims.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/none.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/parser.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/parser_option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/registered_claims.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/rsa.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/rsa_pss.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/rsa_utils.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/signing_method.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/staticcheck.confis excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/token.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/token_option.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/types.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang-jwt/jwt/v5/validator.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/descriptor/descriptor.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/jsonpb/decode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/jsonpb/encode.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/jsonpb/json.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/protoc-gen-go/descriptor/descriptor.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/ptypes/any/any.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/ptypes/duration/duration.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/ptypes/timestamp/timestamp.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/golang/protobuf/ptypes/wrappers/wrappers.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/cmpopts/equate.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/cmpopts/ignore.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/cmpopts/sort.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/cmpopts/struct_filter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/google/go-cmp/cmp/cmpopts/xform.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/CHANGELOG.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/CONTRIBUTING.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/chain.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/makefileis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/client_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/client_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/constants.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/reporter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/server_metrics.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus/server_options.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/slack.pngis excluded by!**/*.png,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/COPYRIGHTis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/callmeta.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/client.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/reporter.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors/server.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/go-grpc-middleware/wrappers.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/LICENSE.txtis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/internal/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/internal/errors.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/internal/errors.protois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/convert.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/fieldmask.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/handler.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshal_httpbodyproto.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshal_json.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshal_jsonpb.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshal_proto.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshaler.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/marshaler_registry.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/mux.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/pattern.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/proto2_convert.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/proto_errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/runtime/query.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/utilities/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/utilities/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/utilities/pattern.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/utilities/readerfactory.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/utilities/trie.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/BUILD.bazelis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/annotations.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/annotations.protois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/annotations_protoopaque.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/buf.gen.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2.protois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/options/openapiv2_protoopaque.pb.gois excluded by!**/*.pb.go,!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/errors.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/handler.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/mux.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/query.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/SECURITY.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/clockwork.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/context.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/ticker.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/jonboulle/clockwork/timer.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/colorable_others.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/colorable_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/go.test.shis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-colorable/noncolorable.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/go.test.shis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_bsd.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_others.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_plan9.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_solaris.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_tcgets.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-isatty/isatty_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/LICENSEis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth_appengine.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth_js.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth_posix.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth_table.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/mattn/go-runewidth/runewidth_windows.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/.travis.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/LICENSE.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/csv.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/table.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/table_with_color.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/util.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/olekukonko/tablewriter/wrap.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/LICENSE.txtis excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/doc.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/eastasianwidth.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/emojipresentation.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/gen_breaktest.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/gen_properties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/grapheme.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/graphemeproperties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/graphemerules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/line.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/lineproperties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/linerules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/properties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/sentence.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/sentenceproperties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/sentencerules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/step.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/width.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/word.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/wordproperties.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/rivo/uniseg/wordrules.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/active_help.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/bash_completionsV2.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/cobra.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/command.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/cobra/powershell_completions.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/.editorconfigis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/.golangci.yamlis excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/flag.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/ip.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/ipnet_slice.gois excluded by!vendor/**,!**/vendor/**vendor/github.com/spf13/pflag/string_array.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/.go-versionis excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/Makefileis excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/OWNERSis excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/README.mdis excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_386.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_aix.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_android.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_arm.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_mips64x.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_mipsx.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_solaris.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_unix.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bolt_windows.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/boltsync_unix.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/bucket.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/cursor.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/db.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/errors.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/errors/errors.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/freelist.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/freelist_hmap.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_386.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_arm.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_mips64x.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_mipsx.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bolt_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/bucket.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/inode.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/meta.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/page.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/types.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/unsafe.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/utils.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/common/verify.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/freelist/array.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/freelist/freelist.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/freelist/hashmap.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/internal/freelist/shared.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/logger.gois excluded by!vendor/**,!**/vendor/**vendor/go.etcd.io/bbolt/mlock_unix.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (13)
bindata/bootkube/bootstrap-manifests/etcd-member-pod.yaml(1 hunks)bindata/etcd/pod.gotpl.yaml(1 hunks)go.mod(5 hunks)pkg/cmd/monitor/monitor_test.go(4 hunks)pkg/cmd/render/env.go(1 hunks)pkg/cmd/render/env_test.go(1 hunks)pkg/cmd/rev/rev_test.go(5 hunks)pkg/etcdcli/etcdcli.go(2 hunks)pkg/etcdcli/etcdcli_pool_test.go(20 hunks)pkg/etcdenvvar/envvarcontroller_test.go(1 hunks)pkg/etcdenvvar/etcd_env.go(3 hunks)pkg/operator/clustermembercontroller/clustermembercontroller.go(2 hunks)pkg/operator/defragcontroller/defragcontroller_test.go(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- pkg/operator/clustermembercontroller/clustermembercontroller.go
- pkg/operator/defragcontroller/defragcontroller_test.go
🔇 Additional comments (19)
pkg/cmd/render/env.go (1)
113-124: LGTM! Environment variable key updated to stable name.The rename from
ETCD_EXPERIMENTAL_MAX_LEARNERStoETCD_MAX_LEARNERSaligns with etcd v3.6.5's promotion of this feature from experimental to stable.pkg/cmd/render/env_test.go (2)
94-100: LGTM! Test expectations correctly updated.The test now expects the stable
ETCD_MAX_LEARNERSkey instead of the experimental variant.
102-108: LGTM! Test expectations correctly updated.Consistent with the other test case update.
pkg/etcdcli/etcdcli.go (2)
23-23: LGTM! Import updated for etcd v3.6.5.The error constants have been reorganized in etcd v3.6.5, moving from
etcdserverto the dedicatederrorspackage.
193-218: LGTM! Error reference updated consistently.The
ErrLearnerNotReadyreference now uses the new import path. The error handling logic remains unchanged.bindata/bootkube/bootstrap-manifests/etcd-member-pod.yaml (1)
49-64: LGTM! Consistent flag update for bootstrap manifest.The feature gate migration matches the change in
bindata/etcd/pod.gotpl.yaml. The same verification about--snapshot-countremoval applies here as well (see comment on pod.gotpl.yaml).pkg/etcdenvvar/etcd_env.go (3)
47-54: LGTM! Fixed environment variables updated to stable keys.The experimental prefixes have been removed from
ETCD_WATCH_PROGRESS_NOTIFY_INTERVALandETCD_WARNING_APPLY_DURATION, aligning with etcd v3.6.5's stable API. Values are correctly preserved.
86-97: LGTM! Documentation updated consistently.The comment now correctly references
ETCD_MAX_LEARNERSinstead of the experimental variant.
358-383: LGTM! Dynamic environment variable key updated.The
getMaxLearnersfunction now returnsETCD_MAX_LEARNERSinstead of the experimental variant, consistent with other changes in this file.pkg/cmd/rev/rev_test.go (5)
14-14: LGTM! Test framework import updated for etcd v3.6.5.The import path reflects the reorganized test framework structure in etcd v3.6.5.
17-36: LGTM! Test updated for new API.The
ClusterClient(t)calls correctly pass the testing parameter, matching the updated etcd test framework signature.
39-70: LGTM! Consistent API updates.All
ClusterClient(t)calls updated consistently throughout the test.
72-104: LGTM! Consistent API updates.All
ClusterClient(t)calls updated consistently throughout the test.
122-153: LGTM! Test cluster setup migrated to new framework API.The changes correctly reflect the etcd v3.6.5 test framework updates:
NewClusterV3→NewCluster*integration.ClusterV3→*integration.ClusterClusterClient()→ClusterClient(t)All call sites in the client pool setup are updated consistently.
bindata/etcd/pod.gotpl.yaml (1)
189-207: ---The removal of
--snapshot-count=10000is intentional and safe.In etcd v3.6.5, the default snapshot-count is 10000, which matches the previously explicit value. Omitting the flag will use the same behavior, so no functional change results from this removal.
pkg/etcdcli/etcdcli_pool_test.go (2)
12-12: LGTM: Test framework import updated.The import path has been correctly updated to use the new etcd v3.6.5 test framework.
33-455: LGTM: Consistent migration to new Cluster API.The migration from
ClusterV3toClusteris applied consistently across all 15 test functions:
integration.NewClusterreplacesNewClusterV3uniformlyGRPCURLis consistently accessed as a field (not a method)ClusterClient(t)correctly passes thetesting.TBparameter- The
newTestPoolhelper function signature properly updated to accept*integration.ClusterThe changes align with the etcd v3.6.5 test framework updates.
pkg/cmd/monitor/monitor_test.go (2)
16-16: LGTM: Test framework import updated.The import path has been correctly updated to use the new etcd v3.6.5 test framework.
34-228: LGTM: Consistent migration to new Cluster API.The migration from
ClusterV3toClusteris complete and consistent:
- Field type at line 34 updated to
*integration.ClustercreateAndStartEtcdTestServerreturn type updated (line 83)integration.NewClusterreplacesNewClusterV3(line 86)GRPCURLconsistently accessed as a field (line 87)- Helper functions
pauseEtcdPeersandstopEtcdPeerssignatures updated (lines 220, 228)The changes align with the etcd v3.6.5 test framework updates and match the migration pattern in other test files.
dusk125
force-pushed
the
etcd-v3.6.5
branch
2 times, most recently
from
282741e to
ca7b84f
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dusk125 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/payload |
Contributor
Contributor
Author
|
/testwith ci/prow/e2e-aws-ovn-serial openshift/etcd#343 |
Contributor
|
@dusk125, |
Contributor
Author
|
/payload-with-prs |
Contributor
Contributor
Author
|
/payload-with-prs 4.21 nightly informing openshift/etcd#343 |
Contributor
|
@dusk125: trigger 68 job(s) of type informing for the nightly release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/22a253d0-b5bf-11f0-8f19-6a0e774a99e5-0 |
Contributor
|
/test ? |
Contributor
|
@hasbro17: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
/test e2e-aws-ovn-etcd-scaling Sanity checking the scaling jobs to double check the behavior of the updated max learner flag. |
dusk125
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Contributor
|
/retest-required |
1 similar comment
Contributor
|
/retest-required |
tjungblu
reviewed
Nov 12, 2025
| exec etcd \ | ||
| --logger=zap \ | ||
| --experimental-initial-corrupt-check=true \ | ||
| --feature-gates=InitialCorruptCheck=true \ |
Contributor
There was a problem hiding this comment.
not sure whether you saw it on the install bundle, but it fails on the bootstrapping node:
flag provided but not defined: -feature-gates
Usage:
etcd [flags]
Start an etcd server.
etcd --version
Show the version of etcd.
etcd -h | --help
Show the help information about etcd.
etcd --config-file
Path to the server configuration file. Note that if a configuration file is provided, other command line flags and environment variables will be ignored.
etcd gateway
Run the stateless pass-through etcd TCP connection forwarding proxy.
etcd grpc-proxy
Run the stateless etcd v3 gRPC L7 reverse proxy.
Contributor
There was a problem hiding this comment.
ah, shoot. We need the 3.6 image in the nightly 🤦 sorry
Contributor
Author
There was a problem hiding this comment.
ah, shoot. We need the 3.6 image in the nightly 🤦 sorry
Yeah... that's why I stopped retest-requiring :D
Contributor
Author
|
/retest |
Contributor
Author
|
/test e2e-agnostic-ovn |
Contributor
Author
|
/retest-required |
1 similar comment
Contributor
|
/retest-required |
Contributor
Author
|
/retest |
Contributor
|
@dusk125: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the CEO in line with the update to etcd v3.6.5
Depends on openshift/etcd#343