-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDN-4773: Add Azure MSI Env Var for ARO HCP #2465
Conversation
@bryan-cox: This pull request references SDN-4773 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
For ARO HCP, we need to be able to override the authentication type to be MSI. For more information please see openshift/enhancements#1659.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, kyrtapz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest-required |
1 similar comment
/retest-required |
GCP jobs are failing and this change only affects HyperShift deployments. |
@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bryan-cox: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ef5c0ca
into
openshift:master
[ART PR BUILD NOTIFIER] Distgit: cluster-network-operator |
For ARO HCP, we need to be able to override the authentication type to be MSI. For more information please see openshift/enhancements#1659.