Stream metadata prep #4576
Stream metadata prep #4576
Conversation
|
(I tested this locally w/libvirt btw, works fine) |
|
(This can wait for 4.8) |
Nothing external uses it; prep for further cleanups.
cgwalters
force-pushed
the
stream-metadata-prep
branch
from
3a733a5
to
dacc96c
Compare
|
OK, 4.7 is branched; ping for review? |
|
@cgwalters: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
pkg/tfvars/internal/cache/cache.go
Outdated
| q := parsedURL.Query() | ||
| if uncompressedSHA256, ok := q["sha256"]; ok { | ||
| u.uncompressedSHA256 = uncompressedSHA256[0] | ||
| delete(q, "sha256") |
There was a problem hiding this comment.
If the intention is to remove the query value from parsedURL, this is not going to have that effect.
https://play.golang.org/p/vISRRGvej-w
Also, I think it is preferred to use the Del function.
| delete(q, "sha256") | |
| q.Del("sha256") |
There was a problem hiding this comment.
Also needed to re-set the RawQuery. Both fixed.
|
/lgtm cancel |
Prep for openshift/os#477 Clarify internally that this sha256 is uncompressed; the stream will also have the compressed sha256 which we should support verifying too (as well as the size). Since we're now parsing the URL better, use the uncompressed filename as the target name. This makes it much *much* more obvious to users how to manually clean up old images in the cache. We can do this because for both FCOS/RHCOS the filenames contain versions and are immutable - we will never go back and change an image.
cgwalters
force-pushed
the
stream-metadata-prep
branch
from
dacc96c
to
cc24287
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
17 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
ovirt is a flake, nothing related to this PR |
|
@cgwalters: cgwalters unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-ovirt |
|
@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-ovirt In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
cache: Create an internal "urlWithIntegrity" API, use better filename
Prep for openshift/os#477
Clarify internally that this sha256 is uncompressed; the stream
will also have the compressed sha256 which we should support
verifying too (as well as the size).
Since we're now parsing the URL better, use the uncompressed
filename as the target name. This makes it much much more
obvious to users how to manually clean up old images in
the cache. We can do this because for both FCOS/RHCOS
the filenames contain versions and are immutable - we will
never go back and change an image.